Use network service client to query source network #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
During the preflight check the VM importer tries to make sure the specified
spec.networkMapping[x].sourceNetwork
in VirtualMachineImport exists for OpenStack imports.The existing implementation seems not to work anymore with the latest OpenStack versions.
Solution:
Make use of the NewNetworkV2 ServiceClient to query for the specified source network.
Related Issue:
harvester/harvester#7432
Test plan:
Case 1
The test plan makes use of our internal OpenStack test environment.
Secret
andOpenstackSource
resources to be able to access the test environment.default/vlan1
exists in Harvester.