Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: moved wallet connection feature from staking to global accessible component (#498) #762

Merged
merged 23 commits into from
Nov 22, 2023
Merged

feat: moved wallet connection feature from staking to global accessible component (#498) #762

merged 23 commits into from
Nov 22, 2023

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Nov 22, 2023 •
edited
Loading

Description:

  • Rearranged nav bar to add wallet connect component
  • Removed wallet connect component in Staking
  • Fixing unit tests to adapt new changes

Related issue(s):

Fixes #498

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

quiet-node and others added 22 commits November 22, 2023 12:20
@quiet-node @svienot
update: rearranged TopNavBar
ed3d40b 
- moved network dropdown down to the search bar row
- added new connect wallet button

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: added WalletChoser component to TopNavBar component
881bf19 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
feat: added connecting wallet logic to Navbar
045b9c4 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: added accountID to wallet section after connected
2136fe3 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: added new logoURL field to WalletDriver class
12c2634 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: added new wallet icon to connect wallet button
6e99383 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
style: smaller connect wallet button
b445c3c 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
dapp-feat: added new WalletInfo component
c09a7d7 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
test: fixed unit test to match with new UI
cd6bb06 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update(style+test): restyled connect wallet button and fix correspond…
8315974 
…ed unit tests

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
style: thinner network selector's border
334f3bb 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: removed connect button in Stake component and fix corresponde…
e9a4038 
…d unit test

- in the test, added topNavBarWrapper component to trigger #connectWalletButton button and execute wallet connect logic

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: added guard conditions to router-link
86fc6c0 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: used copyable component for copyable content in WalletInfo co…
c289115 
…mponent

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: re-order wallet logo urls
13b6314 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
feat: integrated change wallet account feature to WalletInfo component
d2f3de4 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
test: fixed unit tests
e9e5e16 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: reworked grid width layout
b06aaa2 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node @svienot
update: removed Disconnect button in Staking.vue component
b99b7fe 
Signed-off-by: Logan Nguyen <[email protected]>
@svienot
Restore styling of network selector.
234943f 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Fix responsiveness of TopNavBar.vue
1eefc34 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Remove focus ring for network drop-down-menu.
58e6346 
Signed-off-by: Simon Viénot <[email protected]>
@quiet-node quiet-node added the enhancement New feature or request label Nov 22, 2023
@quiet-node quiet-node self-assigned this Nov 22, 2023
@quiet-node quiet-node force-pushed the 00498-(phase-2.b)-Wallet-connection-should-be-accessible-globally branch from 2a2a13c to 36f145b Compare November 22, 2023 15:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.4% 33212 / 38000
🔵 Statements 87.4% 33212 / 38000
🔵 Functions 66.67% 816 / 1224
🔵 Branches 83.58% 3660 / 4379
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/SearchBar.vue 52.77% 66.66% 16.66% 52.77% 28-40, 47, 94-95, 97-110, 113-183, 186
src/components/TopNavBar.vue 95.71% 94.11% 63.63% 95.71% 47, 221-233, 243-244
src/components/staking/WalletChooser.vue 94.55% 86.66% 45.45% 94.55% 103, 114-115, 118-119, 122-124
src/components/wallet/WalletInfo.vue 96.05% 90% 66.66% 96.05% 57-59, 159-161, 189-191
src/pages/Staking.vue 85.24% 84.69% 61.9% 85.24% 143-148, 158-186, 308-309, 315-338, 366, 371, 415-416, 427-428, 459-474, 494-495
src/utils/wallet/WalletDriver_Blade.ts 41.34% 100% 20% 41.34% 52-87, 90-100, 103-104, 111-121, 124-131, 138-151, 154-168, 171-178
src/utils/wallet/WalletDriver_Hashpack.ts 55.42% 100% 37.5% 55.42% 55-56, 65-66, 74-82, 85-87, 100-157
src/utils/wallet/WalletDriver_Metamask.ts 35.15% 100% 13.33% 35.15% 65-94, 97-99, 102-124, 127-149, 152-178, 181-182, 191-214, 217-229, 233-255, 258-263, 277-279, 281-293
Generated in workflow #567

@svienot svienot force-pushed the 00498-(phase-2.b)-Wallet-connection-should-be-accessible-globally branch from 36f145b to 58e6346 Compare November 22, 2023 16:26
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
0.8% 0.8% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@quiet-node quiet-node merged commit 7c8195a into main Nov 22, 2023
5 of 6 checks passed
@quiet-node quiet-node deleted the 00498-(phase-2.b)-Wallet-connection-should-be-accessible-globally branch November 22, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees

@quiet-node quiet-node

Labels
enhancement New feature or request
Projects
Smart Contract Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wallet connection should be accessible globally
2 participants
@quiet-node @svienot