Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up smart contract verification feature flag #770

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Nov 24, 2023

Description:

  • Remove the VITE_APP_ENABLE_VERIFICATION_UI_PHASE2 environment variable
  • Update the processing of the networks-config.json file such that (for each configured network) the SC verification may be disabled in either of the following cases:
    • sourcifySetup property is omitted from the configuration (this ensures compatibility with networks-config.json used before the introduction of SC verification)
    • sourcifySetup = null
    • sourcifySetup.activate = false

Related issue(s):

Fixes #769

Notes for reviewer:

In the static networks configuration, we leave the activate flag to true with empty verification URLs. The static activation is currently needed by unit tests. In an ideal world, since the static config is the fallback in case a custom networks-config.json file fails to be read/decoded, we would want activate = false.

@svienot svienot requested a review from ericleponner November 24, 2023 13:53
Copy link

github-actions bot commented Nov 24, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.46% 33215 / 37979
🔵 Statements 87.46% 33215 / 37979
🔵 Functions 66.8% 819 / 1226
🔵 Branches 83.65% 3674 / 4392
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/contract/ContractByteCodeSection.vue 98.4% 84.61% 25% 98.4% 139, 152-153
src/schemas/NetworkRegistry.ts 91.71% 76.81% 91.66% 91.71% 79-80, 85-86, 122-123, 141-143, 146-147, 204, 208-215, 259-261, 265-267, 269, 276-277
Generated in workflow #571

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
22.5% 22.5% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@svienot svienot merged commit 89e6203 into main Nov 27, 2023
5 of 6 checks passed
@svienot svienot deleted the fix-verification-feature-flag branch November 27, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean-up smart contract verification feature flag
2 participants