Clean-up smart contract verification feature flag #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
VITE_APP_ENABLE_VERIFICATION_UI_PHASE2
environment variablenetworks-config.
json file such that (for each configured network) the SC verification may be disabled in either of the following cases:sourcifySetup
property is omitted from the configuration (this ensures compatibility withnetworks-config.json
used before the introduction of SC verification)sourcifySetup = null
sourcifySetup.activate = false
Related issue(s):
Fixes #769
Notes for reviewer:
In the static networks configuration, we leave the
activate
flag to true with empty verification URLs. The static activation is currently needed by unit tests. In an ideal world, since the static config is the fallback in case a customnetworks-config.json
file fails to be read/decoded, we would wantactivate = false
.