Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 810 missing sender account in graph #814

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 21, 2023

Description:

Fixes the way transfer graph is modified to appear "before reward payment".

Related issue(s):

Fixes #810

Notes for reviewer:

Screenshot 2023-12-21 at 16 26 23

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svienot svienot requested a review from ericleponner December 21, 2023 16:35
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.23% 32644 / 36996
🔵 Statements 88.23% 32644 / 36996
🔵 Functions 66.72% 788 / 1181
🔵 Branches 84.39% 3650 / 4325
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/TransactionTools.ts 80.31% 63.39% 77.77% 80.31% 30-32, 36-37, 39-40, 52-53, 63-64, 75-76, 87-88, 93-134, 137-148, 302-303, 315-316, 331-332
Generated in workflow #605

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@svienot svienot merged commit 47aacb9 into main Dec 21, 2023
4 of 5 checks passed
@svienot svienot deleted the 00810-missing-sender-account-in-graph branch December 21, 2023 16:45
svienot added a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Account 0.0.800 Sender Information for transaction
2 participants