-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor web3 tests code #10293
Refactor web3 tests code #10293
Conversation
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
# Conflicts: # hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallDynamicCallsTest.java # hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/service/OpcodeServiceTest.java
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
...a-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallDynamicCallsTest.java
Outdated
Show resolved
Hide resolved
...a-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallDynamicCallsTest.java
Show resolved
Hide resolved
...ra-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallNestedCallsTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10293 +/- ##
=========================================
Coverage 92.19% 92.19%
Complexity 8006 8006
=========================================
Files 980 980
Lines 33444 33444
Branches 4218 4218
=========================================
+ Hits 30833 30834 +1
Misses 1610 1610
+ Partials 1001 1000 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
...irror-web3/src/test/java/com/hedera/mirror/web3/service/AbstractContractCallServiceTest.java
Outdated
Show resolved
Hide resolved
...irror-web3/src/test/java/com/hedera/mirror/web3/service/AbstractContractCallServiceTest.java
Outdated
Show resolved
Hide resolved
...ava/com/hedera/mirror/web3/service/ContractCallServiceERCTokenModificationFunctionsTest.java
Show resolved
Hide resolved
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/service/OpcodeServiceTest.java
Outdated
Show resolved
Hide resolved
…ant extract and remove method Signed-off-by: filev94 <[email protected]>
...irror-web3/src/test/java/com/hedera/mirror/web3/service/AbstractContractCallServiceTest.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/service/OpcodeServiceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
# Conflicts: # hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/service/AbstractContractCallServiceTest.java
...st/java/com/hedera/mirror/web3/service/ContractCallServiceERCTokenReadOnlyFunctionsTest.java
Outdated
Show resolved
Hide resolved
…alance Signed-off-by: filev94 <[email protected]>
...irror-web3/src/test/java/com/hedera/mirror/web3/service/AbstractContractCallServiceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: filev94 <[email protected]>
Signed-off-by: filev94 <[email protected]>
There is a |
persistFungibleToken() refactoring along with the methods used by the return object will be addressed in a future PR. I've mentioned it in the issue |
Description:
Removed similar code from several tests and put it in parent class so that if a change is needed it should be done in one place only. This is the first PR, more might be needed if i find more code that needs to be extracted in a similar way.
Related issue(s):
Fixes #10255
Notes for reviewer:
This pr fixes setup of ContractCallDynamicCallsTest - as a result there are 20+ test fixes in this class
Checklist