-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: versioning bdd test support with overridden TokenType
function
#17723
Conversation
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17723 +/- ##
============================================
+ Coverage 68.97% 68.99% +0.01%
- Complexity 22949 22953 +4
============================================
Files 2646 2646
Lines 99322 99309 -13
Branches 10255 10253 -2
============================================
+ Hits 68512 68516 +4
+ Misses 26927 26910 -17
Partials 3883 3883
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically like this a lot and think this versioning approach will really be nice and rather easy going forward.
(I know this is still in draft but I like it already.)
But of course I can't leave well enough alone so I've suggested more work for this PR which you can either agree with or not. !!!
...a/node/app/service/contract/impl/exec/systemcontracts/hts/tokentype/TokenTypeTranslator.java
Show resolved
Hide resolved
...-node/test-clients/src/main/java/com/hedera/services/bdd/spec/dsl/entities/SpecContract.java
Show resolved
Hide resolved
...-node/test-clients/src/main/java/com/hedera/services/bdd/spec/dsl/entities/SpecContract.java
Outdated
Show resolved
Hide resolved
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/contract/Utils.java
Outdated
Show resolved
Hide resolved
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/TxnVerbs.java
Outdated
Show resolved
Hide resolved
.../main/java/com/hedera/services/bdd/suites/contract/precompile/address_16c/TokenTypeTest.java
Show resolved
Hide resolved
BTW the unit test problem is from |
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
yup |
…nto 17671-versioning-bdd-test
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lukelee-sl
I think we are on the right direction here.
Left some comments and you should change the tag of the PR as it is not only adding tests
...-clients/src/main/resources/contract/contracts_16c/HederaTokenService/HederaTokenService.sol
Show resolved
Hide resolved
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/TxnVerbs.java
Show resolved
Hide resolved
...-node/test-clients/src/main/java/com/hedera/services/bdd/spec/dsl/entities/SpecContract.java
Show resolved
Hide resolved
...ain/java/com/hedera/node/app/service/contract/impl/exec/processors/HtsTranslatorsModule.java
Show resolved
Hide resolved
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
TokenType
function
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
…nto 17671-versioning-bdd-test
Signed-off-by: Luke Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @lukelee-sl !
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but I'm leaving a couple of questions open for your consideration anyway)
Description:
BalanceOf
TokenType
TokenType
Related issue(s):
Fixes #17671
Checklist