-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improved session handling and logging #327
Conversation
Signed-off-by: Michael Kantor <[email protected]>
Coverage report
Show new covered files 🐣
Test suite run success110 tests passing in 11 suites. Report generated by 🧪jest coverage report action from d723d56 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage ? 36.05%
=======================================
Files ? 14
Lines ? 613
Branches ? 79
=======================================
Hits ? 221
Misses ? 392
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Kantor <[email protected]>
I don’t see what has been split here, it still looks like code styling changes along with logging and some session management updates. The updates look solid, however, I still recommend splitting this PR into smaller, more focused ones for clarity. That said, I’m open to moving forward if others feel differently—I don’t want to hold up progress. |
I think a net of 170 lines of code and 6 files changed is an okay sized PR. Here's an example PR into the javascript sdk that is similarily sized - https://github.com/hashgraph/hedera-sdk-js/pull/2631/files I'd say we can probably move forward with this size PR |
The code updates look good to me. It's hard to be confident with the updates though without test coverage especially considering it's mitigating against multiple connection states which would be hard to reproduce. Are there some tests we can add to help raise confidence with these fixes? |
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Great flag. Just pushed a heap of tests to the PR. Could you check again and let me know your thoughts? We'll also have coverage on the connector which was previously not running. |
console.log(`Dapp: Pairing deleted by wallet!`) | ||
// clean up after the pairing for `topic` was deleted. | ||
}) | ||
this.walletConnectClient.on('session_event', this.handleSessionEvent.bind(this)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, these callbacks were refactored in order to make it easier to unit test
Signed-off-by: Michael Kantor <[email protected]>
dd835f4
to
0d99426
Compare
Looks good to me. Is it possible to move this past the finish line quickly and merge it? It’ll be a major help for us at Saucerswap to address WC reliability on our platform. Thanks! |
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Description:
Broken off from #318
This PR suggests a number of fixes to improve the dApp experience:
Improves
Related issue(s):
#254
Fixes #
Notes for reviewer:
This PR can be tested individually by installing the canary release:
Checklist