Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integrated lease methods & moved leases to resources/lease #1328

Merged
merged 12 commits into from
Feb 9, 2025

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Feb 9, 2025

Description

This pull request changes the following:

  • moved leases to resources/lease
  • integrated lease methods

Related Issues

Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
This reverts commit bbb4738.
@jeromy-cannon jeromy-cannon self-assigned this Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   1s ⏱️ -2s
231 tests ±0  231 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 11851a6. ± Comparison against base commit 547ed19.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   3s ⏱️ ±0s
231 tests ±0  231 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 11851a6. ± Comparison against base commit 547ed19.

♻️ This comment has been updated with latest results.

commit cccb522
Author: Jeromy Cannon <[email protected]>
Date:   Sun Feb 9 16:50:29 2025 +0000

    fixed test case

    Signed-off-by: Jeromy Cannon <[email protected]>

commit f7493cd
Author: Jeromy Cannon <[email protected]>
Date:   Sun Feb 9 16:39:27 2025 +0000

    fixed test case

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 7c03383
Author: Jeromy Cannon <[email protected]>
Date:   Sun Feb 9 16:37:02 2025 +0000

    integrated lease methods

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 6728cd1
Author: Jeromy Cannon <[email protected]>
Date:   Sun Feb 9 16:29:13 2025 +0000

    moved leases to resources/lease

    Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon force-pushed the 01275-k8-leases-integration branch from cccb522 to 28b6d17 Compare February 9, 2025 17:18
@jeromy-cannon jeromy-cannon marked this pull request as ready for review February 9, 2025 18:12
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners February 9, 2025 18:12
nathanklick
nathanklick previously approved these changes Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 28m 53s ⏱️ + 3m 10s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 11851a6. ± Comparison against base commit 547ed19.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Feb 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 93.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (547ed19) 22961 19303 84.07%
Head commit (11851a6) 22929 (-32) 19280 (-23) 84.09% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1328) 15 14 93.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (547ed19) to head (11851a6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/lease/interval_lease.ts 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1328   +/-   ##
=======================================
  Coverage   83.02%   83.03%           
=======================================
  Files         125      125           
  Lines       22961    22929   -32     
  Branches     2234     2301   +67     
=======================================
- Hits        19064    19039   -25     
+ Misses       3751     3657   -94     
- Partials      146      233   +87     
Files with missing lines Coverage Δ
src/core/kube/k8_client.ts 93.65% <100.00%> (+0.05%) ⬆️
...kube/k8_client/resources/lease/k8_client_leases.ts 84.61% <100.00%> (ø)
src/core/lease/interval_lease.ts 85.39% <85.71%> (-0.11%) ⬇️

... and 24 files with indirect coverage changes

Impacted file tree graph

Base automatically changed from 01273-k8-pods-integration to main February 9, 2025 18:24
@jeromy-cannon jeromy-cannon dismissed nathanklick’s stale review February 9, 2025 18:24

The base branch was changed.

@jeromy-cannon jeromy-cannon merged commit d990add into main Feb 9, 2025
42 checks passed
@jeromy-cannon jeromy-cannon deleted the 01275-k8-leases-integration branch February 9, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update codebase to use k8.leases methods directly
3 participants