Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update codebase to use k8.pvcs methods directly #1343

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

jeromy-cannon
Copy link
Contributor

…f the fluent pattern

Description

This pull request changes the following:

  • update codebase to use k8.pvcs methods directly

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Feb 10, 2025
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   2s ⏱️ -1s
231 tests ±0  231 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 61975d9. ± Comparison against base commit 8e943b7.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   3s ⏱️ -1s
231 tests ±0  231 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 61975d9. ± Comparison against base commit 8e943b7.

Copy link
Contributor

github-actions bot commented Feb 10, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 27m 38s ⏱️ - 2m 40s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 61975d9. ± Comparison against base commit 8e943b7.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8e943b7) 23065 19352 83.90%
Head commit (61975d9) 23058 (-7) 19345 (-7) 83.90% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1343) 10 10 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (8e943b7) to head (61975d9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
- Coverage   82.83%   82.82%   -0.01%     
==========================================
  Files         127      127              
  Lines       23065    23058       -7     
  Branches     1453     2225     +772     
==========================================
- Hits        19105    19098       -7     
+ Misses       3942     3787     -155     
- Partials       18      173     +155     
Files with missing lines Coverage Δ
src/commands/mirror_node.ts 76.42% <100.00%> (+0.07%) ⬆️
src/commands/network.ts 66.63% <100.00%> (+0.06%) ⬆️
src/core/kube/k8_client/k8_client.ts 96.07% <ø> (-0.27%) ⬇️

... and 47 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon marked this pull request as ready for review February 10, 2025 14:27
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners February 10, 2025 14:27
@jeromy-cannon jeromy-cannon merged commit 3ae7d7f into main Feb 10, 2025
42 checks passed
@jeromy-cannon jeromy-cannon deleted the 01272-k8-pvcs-integration branch February 10, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update codebase to use k8.pvcs methods directly
2 participants