Refactor tests to use redeployed contracts #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests for burnable and freezable contracts have been refactored to use newly deployed contracts. Additionally, these tests have been exported as functions to be used in other testing scenarios, specifically in the newly added stableCoinStudio test suite. This change improves the modularity and reusability of the burnable and freezable tests. Signed-off-by: Marcos Serradilla Diez <[email protected]>
marcosio
requested review from
M-Francia,
MiguelLZPF and
AlbertoMolinaIoBuilders
…ovementsWithOneDeploy
Refactored the HederaTokenManager contract to import IHederaTokenService. Also, revised several test files to enhance modularity and readability. This includes adding new utility functions, updating existing ones, and adjusting the structure of test suites. Signed-off-by: Marcos Serradilla Diez <[email protected]>
marcosio
changed the title
Added 'regularFactory' to utility functions in the 'stableCoinStudio.ts' test file, and rearranged 'pausable' in the HederaTokenManager contract. This enhances flexibility by adjusting the usage of the test file's utility functions and modulating the properties of contracts. Signed-off-by: Marcos Serradilla Diez <[email protected]>
The codes for 'stableCoinFactory' test have been refactored for readability and maintainability. The refactor involves rearranging the existing codes into more proper structured blocks. No new functionalities were added, and existing functionalities were neither removed nor modified. Signed-off-by: Marcos Serradilla Diez <[email protected]>
The export function wrapper for the 'reserve' and 'stableCoinFactory' test suites has been removed to improve clarity. Key functionalities of the tests remain unchanged. Signed-off-by: Marcos Serradilla Diez <[email protected]>
Signed-off-by: Marcos Serradilla Diez <[email protected]>
MiguelLZPF
requested changes
Feb 1, 2024
contracts/test/burnableFreesableRescuableWipeableDeletableRoleManagement.ts
Outdated
Show resolved
Hide resolved
contracts/test/burnableFreesableRescuableWipeableDeletableRoleManagement.ts
Outdated
Show resolved
Hide resolved
…egularFactoryPlus10000 Signed-off-by: Marcos Serradilla Diez <[email protected]>
MiguelLZPF
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for burnable and freezable contracts have been refactored to use newly deployed contracts. Additionally, these tests have been exported as functions to be used in other testing scenarios, specifically in the newly added stableCoinStudio test suite. This change improves the modularity and reusability of the burnable and freezable tests.
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist