Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backend frequency configurable #1132

Merged
merged 3 commits into from
May 27, 2024

Conversation

AlbertoMolinaIoBuilders
Copy link
Contributor

Description

Make backend scheduler frequency configurable through the .env file

Type of change

  • Bug fix (non-breaking change which fixes an issue) 🐞
  • New feature (non-breaking change which adds functionality) ✨
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) 💥
  • This change requires a documentation update 📖

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. 🧪

  • Manual Tests (npm run test)
  • Local Example (npx tsx examples/index.ts)
  • Local Github Actions (act pull_request)

Test Configuration:

  • Node version (latest LTS):
    • 16
    • 18
    • 20

Test Results (if any)

Checklist:

  • Style Guidelines (My code follows the style guidelines of this project) ✅
  • Self-Review (I have performed a self-review of my own code) 👀
  • Code Comments (I have commented my code, particularly in hard-to-understand areas) 💬
  • Documentation Updates (I have made corresponding changes to the documentation) 📚
  • Warning-Free Changes (My changes generate no new warnings) ⚠️
  • Effective Tests (I have added tests that prove my fix is effective or that my feature works) ✔️
  • Local Test Pass (New and existing unit tests pass locally with my changes) ✅
  • Dependency Updates (Any dependent changes have been merged and published in downstream modules) 🔄
  • Spellcheck (I have checked my code and corrected any misspellings) 📝

Copy link
Contributor

@M-Francia M-Francia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the new variable to the doc: readme -> configuration

@AlbertoMolinaIoBuilders AlbertoMolinaIoBuilders marked this pull request as ready for review May 27, 2024 06:51
@AlbertoMolinaIoBuilders AlbertoMolinaIoBuilders merged commit 5e58083 into sprint-44 May 27, 2024
3 of 4 checks passed
@AlbertoMolinaIoBuilders AlbertoMolinaIoBuilders deleted the feat/backend-freq-config branch May 27, 2024 06:52
AlbertoMolinaIoBuilders added a commit that referenced this pull request Jun 21, 2024
* feat: v1.22.0

Signed-off-by: Alberto Molina <[email protected]>

* feat: metamask now associated and grantskyc when creating (#1131)

* feat: metamask now associated and grantskyc when creating

Signed-off-by: Alberto Molina <[email protected]>

* feat: comment removed

Signed-off-by: Alberto Molina <[email protected]>

---------

Signed-off-by: Alberto Molina <[email protected]>

* feat: backend frequency configurable (#1132)

* feat: backend frequency configurable

Signed-off-by: Alberto Molina <[email protected]>

* docs: backend doc updated

Signed-off-by: Alberto Molina <[email protected]>

---------

Signed-off-by: Alberto Molina <[email protected]>

* feat: added new workflow

Signed-off-by: Alberto Molina <[email protected]>

* feat: workflow renamed

Signed-off-by: Alberto Molina <[email protected]>

* fix: script bug fix

Signed-off-by: Alberto Molina <[email protected]>

* fix: workflow api portal curl command fixed

Signed-off-by: Alberto Molina <[email protected]>

* fix: testing the secrets with dumb workflow

Signed-off-by: Alberto Molina <[email protected]>

* fix: small fixes

Signed-off-by: Alberto Molina <[email protected]>

* fix: commit

Signed-off-by: Alberto Molina <[email protected]>

* fix: check all the secrets without displaying them

Signed-off-by: Alberto Molina <[email protected]>

* fix: workflow error fixed

Signed-off-by: Alberto Molina <[email protected]>

---------

Signed-off-by: Alberto Molina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants