Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprint 55 #1231

Merged
merged 17 commits into from
Nov 13, 2024
Merged

Sprint 55 #1231

merged 17 commits into from
Nov 13, 2024

Conversation

MiguelLZPF
Copy link
Contributor

@MiguelLZPF MiguelLZPF commented Nov 11, 2024 •
edited by M-Francia
Loading

Description

Fixes:

  • DCO in Sprint 53 (Fix DCO in Sprint 53 #1204)
  • GitHub Actions versions added as comments
  • Set Harden Runner as the first step in workflows
  • Add permissions for contents read access in workflow files
  • Add Harden Runner step to all publish jobs
  • Versions

Chores:

  • Update GitHub Actions workflow to use bash shell and add security checks
  • Update pre-commit hook to use bash and add prettier check
  • Rename extension to match other workflows
  • Bump version
  • Remove backup workflow file for publishing (Remove backup workflow file for publishing #1223)

New Features:

  • Update Hedera Wallet Connect version to 1.3.4
  • Add support for Mainnet (Add support for Mainnet #1222)
  • Allow users update custom fees throw hedera token manager SC
  • Allow users to manage Custom Fees Role

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

MiguelLZPF and others added 16 commits October 11, 2024 13:20
@MiguelLZPF
Fix DCO in Sprint 53 (#1204)
fc87a25 
Signed-off-by: Miguel_LZPF <[email protected]>
@AlbertoMolinaIoBuilders
fix: github actions versions added as comments
b5ae703 
Signed-off-by: Alberto Molina <[email protected]>
@MiguelLZPF
chore: update GitHub Actions workflow to use bash shell and add secur…
48179bc 
…ity hardening step

Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF
chore: update pre-commit hook to use bash and add prettier check
af3cc9f 
Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF
chore: rename extension to match other workflows
e396790 
Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF
fix: set Harden Runner as the first step to workflows
2994674 
Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF
Merge remote-tracking branch 'origin/main' into sprint-53-dco-fix
059fde2 
Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF
fix: add permissions for contents read access in workflow files
e684e68 
Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF
fix: add Harden Runner step to all publish jobs
655745b 
Signed-off-by: Miguel_LZPF <[email protected]>
@jaime-iobermudez @M-Francia
feat: update hedera wallet version to 1.3.4
7583714 
Signed-off-by: Jaime Bermudez <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
@ManuIOB @M-Francia
fix: [BBND-296] Table responsive (#1210)
33a8d2e 
* fix: tests

Signed-off-by: Manu Fernandez <[email protected]>

* fix: table responsive

Signed-off-by: Manu Fernandez <[email protected]>

* fix: update snapshots

Signed-off-by: Manu Fernandez <[email protected]>

* fix: update snapshots

Signed-off-by: Manu Fernandez <[email protected]>

* fix: tests

Signed-off-by: Manu Fernandez <[email protected]>

* fix: snapshots

Signed-off-by: Mario Francia <[email protected]>

---------

Signed-off-by: Manu Fernandez <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Co-authored-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@M-Francia
chore: bump version
93beb02 
Signed-off-by: Mario Francia <[email protected]>
@M-Francia
fix: versions
295c92e 
Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
chore: remove backup workflow file for publishing (#1223)
ecb2d5a 
Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF
Add support for Mainnet (#1222)
6a763ff 
* feat: add support for MainNet and refactor Hedera account configuration

Signed-off-by: Miguel_LZPF <[email protected]>

* fix: update hardhat configuration file extension from .js to .ts

Signed-off-by: Miguel_LZPF <[email protected]>

* feat: add MainNet test scripts for various contract functionalities

Signed-off-by: Miguel_LZPF <[email protected]>

* fix: remove Mainnet test scripts from package.json

Signed-off-by: Miguel_LZPF <[email protected]>

* fix: update CASHIN_GAS constant to reflect new gas requirements

Signed-off-by: Miguel_LZPF <[email protected]>

---------

Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF
Merge branch 'main' into sprint-55
8efaa26 
Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF MiguelLZPF self-assigned this Nov 11, 2024
@M-Francia @jaime-iobermudez
@AlbertoMolinaIoBuilders @ManuIOB @manuel-campo-iobuilders
Feat/bbnd 405 (#1220)
bf8369e 
* feat: added ICustomFee interface

Signed-off-by: jaime-iobermudez <[email protected]>

* feat: added ICustomFees interface

Signed-off-by: jaime-iobermudez <[email protected]>

* feat: add ICustomFee interface

Signed-off-by: jaime-iobermudez <[email protected]>

* feat: added ICustomFees interface

Signed-off-by: jaime-iobermudez <[email protected]>

* feat: add feeRoleAccount

Signed-off-by: jaime-iobermudez <[email protected]>

* feat: added feeRoleAccount

Signed-off-by: jaime-iobermudez <[email protected]>

* fix: custom fees in metamask sdk

Signed-off-by: Alberto Molina <[email protected]>

* feat: added updateTokenCustomFees smart contract

Signed-off-by: jaime-iobermudez <[email protected]>

* feat: added updateTokenCustomFees smart contract

Signed-off-by: jaime-iobermudez <[email protected]>

* fix: sdk code refactor

Signed-off-by: Alberto Molina <[email protected]>

* fix: import

Signed-off-by: jaime-iobermudez <[email protected]>

* fix: customFees sdk tests

Signed-off-by: jaime-iobermudez <[email protected]>

* feat: [BBND-412] add token manager fee schedule (#1218)

* feat: add token manager option in fee schedule key

* feat: add fee schedule role

Signed-off-by: Manu Fernández <[email protected]>

* feat: add fees role

---------

Signed-off-by: Manu Fernández <[email protected]>

* Feat/bbnd 407 (#1216)

* feat: added function from precompiled

Signed-off-by: Mario Francia <[email protected]>

* feat: added rol for custom fees

Signed-off-by: Mario Francia <[email protected]>

* refactor: keeping naming consistent

Signed-off-by: Mario Francia <[email protected]>

* feat: logics

Signed-off-by: Mario Francia <[email protected]>

* feat: update keccak

Signed-off-by: Mario Francia <[email protected]>

* feat: updated tests

Signed-off-by: Mario Francia <[email protected]>

* feat: updated tests

Signed-off-by: Mario Francia <[email protected]>

* fix: errors

Signed-off-by: Mario Francia <[email protected]>

* fix: code review

Signed-off-by: Mario Francia <[email protected]>

* feat: doc

Signed-off-by: Mario Francia <[email protected]>

* fix: cr

Signed-off-by: Mario Francia <[email protected]>

* fix: cr

Signed-off-by: Mario Francia <[email protected]>

* fix: renamed

Signed-off-by: Mario Francia <[email protected]>

* fix: doc

Signed-off-by: Mario Francia <[email protected]>

---------

Signed-off-by: Mario Francia <[email protected]>

* [BBND-416]  [cli] Modify CreateStableCoinService.ts with new logics (#1219)

* feat: add Smart Contract as option for Custom Fee managment & npm audit fix

Signed-off-by: Manuel Campo <[email protected]>

* fix: add missing prompt (wip)

Signed-off-by: Manuel Campo <[email protected]>

* fix: feeRoleAccount naming

Signed-off-by: Manuel Campo <[email protected]>

---------

Signed-off-by: Manuel Campo <[email protected]>

* fix: wip test

Signed-off-by: Mario Francia <[email protected]>

* fix: test and contracts

Signed-off-by: Mario Francia <[email protected]>

* fix: pipeline

Signed-off-by: Mario Francia <[email protected]>

* chore: bump versions

Signed-off-by: Mario Francia <[email protected]>

* fix: sdk fixed fee hbar

Signed-off-by: Alberto Molina <[email protected]>

* refactor: ref

Signed-off-by: Mario Francia <[email protected]>

* fix: show fee management with metamask (#1221)

Signed-off-by: Manu Fernández <[email protected]>

* fix: sdk customFee test

Signed-off-by: jaime-iobermudez <[email protected]>

* fix: test

Signed-off-by: jaime-iobermudez <[email protected]>

* Revert "fix: test"

This reverts commit eb01c83.

* fix: fee management permissions (#1224)

Signed-off-by: Manu Fernández <[email protected]>

* fix: test

Signed-off-by: Mario Francia <[email protected]>

* fix: test

Signed-off-by: Mario Francia <[email protected]>

* fix: sdk test

Signed-off-by: jaime-iobermudez <[email protected]>

* fix: sdk test

Signed-off-by: jaime-iobermudez <[email protected]>

* fix: test

Signed-off-by: jaime-iobermudez <[email protected]>

* fix: ui refactored fees access

Signed-off-by: Alberto Molina <[email protected]>

* fix: update snapshot

Signed-off-by: Mario Francia <[email protected]>

* fix: cli fees custom

Signed-off-by: Alberto Molina <[email protected]>

* fix: contract test and improvements

Signed-off-by: Mario Francia <[email protected]>

* fix: update test web (#1230)

Signed-off-by: Manu Fernández <[email protected]>

---------

Signed-off-by: jaime-iobermudez <[email protected]>
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Manuel Campo <[email protected]>
Co-authored-by: jaime-iobermudez <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: manuel-campo-iobuilders <[email protected]>
@MiguelLZPF MiguelLZPF marked this pull request as ready for review November 12, 2024 08:23
@MiguelLZPF MiguelLZPF requested review from a team as code owners November 12, 2024 08:23
mishomihov00
mishomihov00 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved only these files:
.github/actions/create-env-file/action.yaml
.github/workflows/test-contracts.yaml

gregscullard
gregscullard approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@gregscullard gregscullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelLZPF MiguelLZPF merged commit 4458e9e into main Nov 13, 2024
13 checks passed
@MiguelLZPF MiguelLZPF deleted the sprint-55 branch November 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-Francia M-Francia M-Francia approved these changes

@gregscullard gregscullard gregscullard approved these changes

@rbarker-dev rbarker-dev rbarker-dev approved these changes

@mishomihov00 mishomihov00 mishomihov00 approved these changes

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

@RaphaelMessian RaphaelMessian Awaiting requested review from RaphaelMessian RaphaelMessian is a code owner automatically assigned from hashgraph/developer-advocates

Assignees

@MiguelLZPF MiguelLZPF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MiguelLZPF @M-Francia @gregscullard @rbarker-dev @mishomihov00 @AlbertoMolinaIoBuilders @jaime-iobermudez @ManuIOB