Backport of Increase max message receive size. into release/1.1.x #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #357 to be assessed for backporting due to the inclusion of the label backport/1.1.
🚨
The person who merged in the original PR is:
@hashi-derek
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
This commit changes the grpc-proxy internal to dataplane so that it can send / receive messages up to 50MB. Prior to this change, it would only allow 4MB payloads, which was insufficient for some proxies that has a very large number of upstreams. Whenever this limit was exceeded, the gRPC connection to the server would be terminated, causing a reconnect to occur, which would then repeat the issue all over again.
Because the underlying grpc-proxy library did not support configuring this field, I have had to refer to a custom fork of my own. Eventually if the corresponding change makes its way upstream, the go.mod file can point back to the original codebase.
It's worth noting that the lineage of this library is a bit confusing.
https://github.com/mwitkow/grpc-proxy is the original codebase, which contained a bug at the time it was added to dataplane. A different author had fixed the bug in their own fork, and I suppose it took a while to get it merged, so we pointed to their repo instead: github.com/adamthesax/grpc-proxy .
So rather than going two-forks-deep for this fix, I checked that the adamthesax bugfix had been merged upstream into mwitkow and forked from there. Based on code comparisons, they appear to be mostly the same, so this should be safe.
Below is the comparison of my own custom changes against the upstream.
mwitkow/grpc-proxy@master...hashi-derek:grpc-proxy:derekm/rename-packages
Overview of commits