Upgrade to using hashicorp/go-metrics instead of armon/go-metrics #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This necessarily also pulls in the upgraded version of the consul-server-connection-manager library.
mkeeler
added
the
pr/no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This necessarily also pulls in the upgraded version of the consul-server-connection-manager library. That library has dual compatibility for both metrics modules and to enable using hashicorp/go-metrics build tags are used.
Additionally I have enabled a linter to ensure only the hashicorp/go-metrics module is used in this repo ensuring that all metrics will flow to the same module.