NET-6812 Allow meshGateway.enabled when resource-apis experiment is enabled #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
theme/mesh-gw
pr/no-changelog
nathancoleman
force-pushed
the
enable-mesh-gateways-with-experiment
branch
from
57db171 to
8ed455a
Compare
nathancoleman
requested review from
a team,
andrewstucki and
NiniOak
and removed request for
a team
nathancoleman
force-pushed
the
enable-mesh-gateways-with-experiment
branch
from
8ed455a to
dda37eb
Compare
NiniOak
reviewed
Dec 5, 2023
jm96441n
reviewed
Dec 5, 2023
NiniOak
approved these changes
Dec 6, 2023
nathancoleman
changed the title
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
…3285) * Allow meshGateway.enabled when resource-apis experiment is enabled * Exclude v1 mesh gateway templates when resource-apis experiment enabled * Enable mesh gateway for bats test where new gate added * Combine if statements for gating v2 configmap component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Currently, attempting to install with
meshGateway.enabledreturns the following error today:$ helm upgrade --install consul ~/workspaces/consul-k8s/charts/consul --values ./values.yaml --namespace consul --create-namespace Error: UPGRADE FAILED: execution error at (consul/templates/_helpers.tpl:510:2): When the value global.experiments.resourceAPIs is set, meshGateway.enabled is currently unsupported.This made sense for the 1.17.0 release of Consul when Mesh Gateway was not implemented for v2; however, we're currently building the v2 mesh gateway and need to be able to
helm installwith it enabled. The implementation will be sufficient enough for Consul 1.18 to ship without this guard in place.This PR does three things:
meshGateway.enabledto be set at the same time asexperiments[].resource-apis(which is what enables v2 things)meshGateway.enabledexperiments[].resource-apisis set (meaning v2 is enabled)How I've tested this PR:
See
helminstall command above, verify it does not return error and obeys the 3 items aboveHow I expect reviewers to test this PR:
See above
Checklist: