fixed incorrect test validation with peering test #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test was performing the wrong connection check, since http should be checking for a '403' - added cluster creation in parallel to speed up test
wilkermichael
commented
Dec 8, 2023
| @@ -350,7 +368,7 @@ func TestPeering_Connect(t *testing.T) { | |||
| // If ACLs are enabled, test that deny intentions prevent connections. | |||
| if c.ACLsEnabled { | |||
| logger.Log(t, "testing intentions prevent connections through the terminating gateway") | |||
| k8s.CheckStaticServerConnectionFailing(t, staticClientOpts, staticClientName, externalServerHostnameURL) | |||
There was a problem hiding this comment.
@t-eckert this was the line causing the issue with the test. It should be checking for 403
wilkermichael
changed the title
wilkermichael
added
backport/1.3.x
t-eckert
approved these changes
Dec 11, 2023
wilkermichael
deleted the
mw/NET-5808-fix-peering-enable-tproxy-acceptance
branch
2 tasks
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
fixed flake with peering test - test was performing the wrong connection check, since http should be checking for a '403' - added cluster creation in parallel to speed up test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
Checklist