[NET-6809] Add chart related labels for mesh gateway deployments #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm96441n
added
theme/mesh-gw
pr/no-changelog
jm96441n
requested review from
a team,
missylbytes and
sarahalsmiller
and removed request for
a team
jm96441n
commented
Dec 18, 2023
| @@ -196,6 +201,9 @@ func (c *Command) init() { | |||
| "K8s namespaces to explicitly deny. Takes precedence over allow. May be specified multiple times.") | |||
| c.flagSet.StringVar(&c.flagReleaseName, "release-name", "consul", "The Consul Helm installation release name, e.g 'helm install <RELEASE-NAME>'") | |||
| c.flagSet.StringVar(&c.flagReleaseNamespace, "release-namespace", "default", "The Consul Helm installation namespace, e.g 'helm install <RELEASE-NAME> --namespace <RELEASE-NAMESPACE>'") | |||
| c.flagSet.StringVar(&c.flagAppName, "app-name", "consul", "The Consul application name use when installing consul") | |||
There was a problem hiding this comment.
I don't know how I feel about the descriptions for these flags, any feedback/suggestions would be appreciated
|
@jm96441n thoughts on instead adding these to |
|
that's a good idea! lemme update this and give that a shot |
jm96441n
force-pushed
the
NET-6809-chart-related-labels
branch
from
5c92ab1 to
bb90713
Compare
|
This PR will be further simplified by #3397 |
jm96441n
force-pushed
the
NET-6809-chart-related-labels
branch
from
bb90713 to
2a9a5fb
Compare
nathancoleman
approved these changes
Dec 19, 2023
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
* use set labels for setting labels on deployments * incorporate changes for setting labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
Checklist