Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.x Sync up sameness acceptance tests with main #3403

Merged

Conversation

wilkermichael
Copy link
Contributor

@wilkermichael wilkermichael commented Dec 19, 2023

Changes proposed in this PR

  • This PR syncs up changes made to the main sameness test with 1.2.x. It avoids localities as that is a 1.3.x+ feature.

How I've tested this PR

How I expect reviewers to test this PR

Checklist

@wilkermichael wilkermichael changed the base branch from main to release/1.2.x December 19, 2023 18:41
@wilkermichael wilkermichael force-pushed the mw/sync-up-sameness-with-main-release-1-2-x branch from f07a946 to 4c6786e Compare December 19, 2023 20:22
@wilkermichael wilkermichael added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Dec 19, 2023
@wilkermichael wilkermichael marked this pull request as ready for review December 19, 2023 20:28
@wilkermichael wilkermichael changed the title Mw/sync up sameness with main release 1 2 x Release 1.2.x Sync up sameness acceptance tests with main Dec 19, 2023
@wilkermichael wilkermichael force-pushed the mw/sync-up-sameness-with-main-release-1-2-x branch from 4c6786e to fa8d28c Compare December 19, 2023 22:20
@wilkermichael wilkermichael merged commit a21d6cd into release/1.2.x Dec 19, 2023
3 checks passed
@wilkermichael wilkermichael deleted the mw/sync-up-sameness-with-main-release-1-2-x branch December 19, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants