Fixes tolerations not working #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missylbytes
changed the title
|
Note: Still working on bats, they pass locally (well technically right now I have them intentionally failing to figure out the jq parsing issue). |
missylbytes
changed the title
missylbytes
requested review from
a team,
NiniOak and
xwa153
and removed request for
a team
jm96441n
reviewed
Sep 20, 2024
jm96441n
reviewed
Sep 20, 2024
jm96441n
reviewed
Sep 20, 2024
jm96441n
reviewed
Sep 20, 2024
missylbytes
commented
Sep 23, 2024
|
|
||
| local actual=$(echo "$spec" | jq '.[17]') |
There was a problem hiding this comment.
This was already tested on line 90
missylbytes
commented
Sep 23, 2024
| local actual=$(echo "$spec" | jq '.[13]') | ||
| [ "${actual}" = "\"foo: bar\"" ] | ||
|
|
||
| local actual=$(echo "$spec" | jq '.[14] | ."-tolerations=- key"') |
There was a problem hiding this comment.
Tolerations were moved to their own test
missylbytes
added
backport/1.6.x
jm96441n
approved these changes
Sep 23, 2024
missylbytes
deleted the
net-10843-cannot-add-tolerations-to-apigateway
branch
This was referenced Sep 23, 2024
|
Removed the 1.1.x backport label as the gateway-resources-job did not exist at that time. |
2 tasks
missylbytes
added a commit
that referenced
this pull request
Sep 24, 2024
missylbytes
added a commit
that referenced
this pull request
Sep 24, 2024
missylbytes
added a commit
that referenced
this pull request
Sep 24, 2024
missylbytes
added a commit
that referenced
this pull request
Sep 24, 2024
missylbytes
pushed a commit
that referenced
this pull request
Sep 24, 2024
Fixes tolerations not working for API Gateways (#4315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
Same as above
Checklist