-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NET-11187] Nightly openshift basic test #4424
Merged
+394
−2
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3d7288b
basic test cases
sarahalsmiller d354c99
test fixtures
sarahalsmiller fd6d08c
working openshift test
sarahalsmiller 406c679
openshift test packages
sarahalsmiller fedcbde
update Makefile
sarahalsmiller b400a67
Correct name of added Make target
nathancoleman df79cf0
Correct import blocking
nathancoleman d0c0ba7
Make assertions more robust, clean up code/comments
nathancoleman 7da5014
Add a PR trigger for acceptance tests
nathancoleman 9366c64
Use different source for branch name provided to workflow
nathancoleman ba5c14e
Rename PR-triggered workflow
nathancoleman 7840a05
Use local checkout of Helm chart for installation
nathancoleman b4fb68c
Use workspace from environment
nathancoleman f991992
Add the hashicorp helm repo as part of test setup
nathancoleman 44d9361
new chart path
sarahalsmiller 9daa878
Remove unused code, retry gateway connection, improve logging
nathancoleman 7a0f066
Remove PR trigger for nightly acceptance tests
nathancoleman 4c91a8f
move cleanup calls before the error so they'll clean up even if it er…
sarahalsmiller 4ff0d07
Update acceptance/tests/openshift/main_test.go
sarahalsmiller 44096fd
update flags to use config
sarahalsmiller 2963997
readd pr trigger test to validate change
sarahalsmiller bac0643
add license mounting config
sarahalsmiller a37774c
fix cert reference
sarahalsmiller fb8a09c
Merge branch 'main' into nightly-openshift-run
sarahalsmiller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make assertions more robust, clean up code/comments
commit d0c0ba76bd98b970d1beca68a750c2d4fd3531f5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,4 +56,4 @@ metadata: | |
name: backend | ||
namespace: backend | ||
spec: | ||
protocol: http | ||
protocol: http |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,4 +59,4 @@ metadata: | |
name: frontend | ||
namespace: frontend | ||
spec: | ||
protocol: http | ||
protocol: http |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,4 +27,4 @@ spec: | |
to: | ||
- group: "" | ||
kind: Service | ||
name: frontend | ||
name: frontend |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh got it, thanks I was wondering about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know theres also some common test defaults that get set through those helper functions so it may be worth using those in the near future so the same defaults get set across our tests.