Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-7630 - Fix TXT record creation on node queries #20483

Merged
merged 1 commit into from
Feb 6, 2024
Merged

NET-7630 - Fix TXT record creation on node queries #20483

merged 1 commit into from
Feb 6, 2024

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Feb 5, 2024

Description

  • TXT records were not working on node lookups.
  • audited the failing tests in the service and node lookups file and created sub tasks for them related to the theme of what needed to be implemented.

Testing & Reproduction steps

CI

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.18 labels Feb 5, 2024
@jmurret jmurret marked this pull request as ready for review February 5, 2024 21:53
@jmurret jmurret requested a review from DanStough February 5, 2024 21:53
@jmurret jmurret enabled auto-merge (squash) February 5, 2024 23:37
@jmurret jmurret requested a review from DanStough February 6, 2024 03:04
@jmurret jmurret merged commit 7d4deda into main Feb 6, 2024
90 checks passed
@jmurret jmurret deleted the jm/NET-7630 branch February 6, 2024 14:53
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Feb 6, 2024
Merged
4 tasks
jmurret added a commit that referenced this pull request Feb 6, 2024
@jmurret
NET-7630 - Fix TXT record creation on node queries (#20483)
351b34f
jmurret added a commit that referenced this pull request Feb 6, 2024
@hc-github-team-consul-core @jmurret
Backport of NET-7630 - Fix TXT record creation on node queries into r…
a118821 
…elease/1.18.x (#20500)

NET-7630 - Fix TXT record creation on node queries (#20483)

Co-authored-by: John Murret <[email protected]>
@dhiaayachi dhiaayachi mentioned this pull request Sep 27, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanStough DanStough DanStough approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmurret @DanStough