New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata: memoize the parsed build versions #22113

Merged

rboyer merged 4 commits into main from rboyer/memoize-build-version

Feb 3, 2025

Member

rboyer commented Jan 31, 2025

Description

There will only be a small set of consul build versions that a single consul server will witness. Inside of metadata.IsConsulServer we use a very expensive function in the hashicorp/go-version library to parse these into read-only *version.Version structs all over Consul.

Memoize these in a package cache map. Likely the thing will only have like 2 keys in it ever over the life of the process.


          metadata: memoize the parsed build versions

fcf694d

rboyer requested review from nathancoleman, ndhanushkodi and dhiaayachi

January 31, 2025 22:15

rboyer self-assigned this

rboyer requested a review from a team as a code owner

January 31, 2025 22:15

rboyer added the pr/no-metrics-test label

nathancoleman reviewed

View reviewed changes

agent/metadata/build.go Outdated Show resolved Hide resolved

rboyer and others added 3 commits

January 31, 2025 16:31


          changelog

ba856ad


          Update agent/metadata/build.go

1f21f81

Co-authored-by: Nathan Coleman <[email protected]>


          call this as late as possible

760167d

dhiaayachi added the backport/all label

dhiaayachi approved these changes

View reviewed changes

Collaborator

dhiaayachi left a comment

LGTM! 🚀

rboyer merged commit 00d74ab into main

102 of 103 checks passed

rboyer deleted the rboyer/memoize-build-version branch

February 3, 2025 22:22

hc-github-team-consul-core added backport/1.20 backport/ent/1.15 backport/ent/1.18 backport/ent/1.19 labels

hc-github-team-consul-core mentioned this pull request

Backport of metadata: memoize the parsed build versions into release/1.20.x #22118

Merged

Collaborator

hc-github-team-consul-core commented Feb 4, 2025

📣 Hi @rboyer! a backport is missing for this PR [22113] for versions [1.15,1.18,1.19,1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

2 similar comments

Collaborator

hc-github-team-consul-core commented Feb 5, 2025

📣 Hi @rboyer! a backport is missing for this PR [22113] for versions [1.15,1.18,1.19,1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Feb 5, 2025

📣 Hi @rboyer! a backport is missing for this PR [22113] for versions [1.15,1.18,1.19,1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Feb 7, 2025

📣 Hi @rboyer! a backport is missing for this PR [22113] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

4 similar comments

Collaborator

hc-github-team-consul-core commented Feb 8, 2025

📣 Hi @rboyer! a backport is missing for this PR [22113] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Feb 9, 2025

📣 Hi @rboyer! a backport is missing for this PR [22113] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Feb 10, 2025

📣 Hi @rboyer! a backport is missing for this PR [22113] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Feb 10, 2025

📣 Hi @rboyer! a backport is missing for this PR [22113] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/all backport/ent/1.15 backport/ent/1.18 backport/ent/1.19 backport/1.20 pr/no-metrics-test