Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix generate registry command #445

Merged
merged 3 commits into from
Oct 24, 2023
Merged

[cli] Fix generate registry command #445

merged 3 commits into from
Oct 24, 2023

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Oct 23, 2023

Description

The argument for the generate registry command is improperly read causing the command to emit the generated files into the current folder rather than a folder having the name of the registry.

Reminders

  • Add CHANGELOG.md entry

@angrycub angrycub added type/bug stage/accepted theme/cli Relates to the CLI in general labels Oct 23, 2023
@angrycub angrycub self-assigned this Oct 23, 2023
@angrycub angrycub marked this pull request as ready for review October 23, 2023 19:50
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angrycub angrycub merged commit db9f7f8 into main Oct 24, 2023
19 checks passed
@angrycub angrycub deleted the b-cli-generate-registry branch October 24, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/accepted theme/cli Relates to the CLI in general type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants