[generate] Print relative variable names for dep variables #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
added
type/bug
stage/accepted
theme/template/variable
angrycub
changed the title
angrycub
changed the title
| @@ -78,7 +78,13 @@ func (v *Variable) Equal(ivp *Variable) bool { | |||
|
|
|||
| func (v *Variable) AsOverrideString(pID pack.ID) string { | |||
| var out strings.Builder | |||
| out.WriteString(fmt.Sprintf(`# variable "%s"`, v.Name)) | |||
|
|
|||
| fqvn := strings.Join([]string{pID.String(), v.Name.String()}, ".") | |||
There was a problem hiding this comment.
I love how everyone can immediately know what an fqvn is :)
Co-authored-by: Piotr Kazmierczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing variable qualifiers for non-root pack variables.
Reminders
CHANGELOG.mdentryI'm pretty sure that this error is not in a release, so can probably omit CL.