Tweaks helpers and auto-generated pack #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenomitch
changed the title
angrycub
approved these changes
Oct 25, 2023
nomad-pack
Outdated
There was a problem hiding this comment.
Looks like you picked up a test build in this changeset.
mikenomitch
force-pushed
the
removes-mounts-helper
branch
from
a656229 to
714b7c3
Compare
mikenomitch
force-pushed
the
removes-mounts-helper
branch
from
714b7c3 to
401a9b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the mounts helper. There are already "complex" examples for helpers and this is probably too in the weeds and distracting for new users.
Also adds type to service helper since "nomad" is an option
Also adds dependency information into the metadata template
Reminders
CHANGELOG.mdentry