generated from hashicorp/packer-plugin-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use CMD/ENTRYPOINT from source image by default #167
Merged
lbajolet-hashicorp
merged 6 commits into
hashicorp:main
from
gardar:default-entrypoint_cmd
Dec 22, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d1d11c2
feat: fetch cmd/entrypoint from source image
gardar 7d1e93d
feat: use CMD/ENTRYPOINT from source image by default
gardar 7c700f4
fix: lint
gardar c921cb4
fix: pass null entrypoint/cmd as empty array to avoid it being popula…
gardar e8ea3da
fix: make sure image has been pulled before looking up default cmd/en…
gardar 1999e90
docker: run goimports on set_defaults to lint
lbajolet-hashicorp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package docker | ||
|
||
import ( | ||
"context" | ||
"strings" | ||
|
||
"github.com/hashicorp/packer-plugin-sdk/multistep" | ||
) | ||
|
||
type StepSetDefaults struct{} | ||
|
||
func (s *StepSetDefaults) Run(ctx context.Context, state multistep.StateBag) multistep.StepAction { | ||
driver := state.Get("driver").(*DockerDriver) | ||
config := state.Get("config").(*Config) | ||
|
||
// Fetch default CMD and ENTRYPOINT | ||
defaultCmd, _ := driver.Cmd(config.Image) | ||
defaultEntrypoint, _ := driver.Entrypoint(config.Image) | ||
|
||
// Set defaults if not provided by the user | ||
hasCmd, hasEntrypoint := false, false | ||
for _, change := range config.Changes { | ||
if strings.HasPrefix(change, "CMD") { | ||
hasCmd = true | ||
} else if strings.HasPrefix(change, "ENTRYPOINT") { | ||
hasEntrypoint = true | ||
} | ||
} | ||
|
||
if !hasCmd && defaultCmd != "" { | ||
config.Changes = append(config.Changes, "CMD "+defaultCmd) | ||
} | ||
if !hasEntrypoint && defaultEntrypoint != "" { | ||
config.Changes = append(config.Changes, "ENTRYPOINT "+defaultEntrypoint) | ||
} | ||
|
||
return multistep.ActionContinue | ||
} | ||
|
||
func (s *StepSetDefaults) Cleanup(state multistep.StateBag) {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change broke our builds because if both values are defined they are connected. We only defined
ENTRYPOINT
and got theCMD
from the base image which then was used as default arguments in our entrypoint.