Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F expose openstack image #3905

Closed

Conversation

jcejohnson
Copy link

@jcejohnson jcejohnson commented Sep 20, 2016

Adds image_info_file and image_info_content configuration options to the Openstack builder so that post-processors have access to the image id (e.g. -- via the artifice post-processor).

Relates to #2678

@jcejohnson
Copy link
Author

Is there anything I need to do on this?

@rickard-von-essen
Copy link
Collaborator

I'm not sure this is a good way forward.

I think fixing the shell-local post-processor to run once per artifact expose Artifact.Id to it is a better way forward.

@jcejohnson
Copy link
Author

I took this route so that any post-processor would have access to the image id.
Would Artifact.Id be the actual Openstack image ID or a packer ID?

@rickard-von-essen
Copy link
Collaborator

OpenStack image ID

@jcejohnson
Copy link
Author

Perfect! Point me in the right direction and I'll see what I can do.

@rickard-von-essen
Copy link
Collaborator

Point me in the right direction and I'll see what I can do.

See #3671

@jcejohnson
Copy link
Author

I've updated the PR based on your suggestion.
This change doesn't attempt to address the full scope of #3671. Instead, it simply uses artifact.Id() as the template .Artifact value when artifact.Files() returns nil. This maintains backward compatibility when a builder produces files while behaving reasonably when it doesn't and removes the need for fake artifacts.
I have also backed out my original changes to builder/openstack/*

@gkuchta
Copy link

gkuchta commented Oct 26, 2016

Any movement on this? It'd be very, very useful, as packer currently uses the nova API for creating images, which doesn't allow you to control whether an image is public/private. This is problematic when used with something like Spinnaker.

@rickard-von-essen
Copy link
Collaborator

@gkuchta It would be better if someone PR'ed #2678

@gkuchta
Copy link

gkuchta commented Oct 26, 2016

@rickard-von-essen agreed. our team is looking at either PR'ing the base builder to use the image api or writing an openstack post-processor longer term.

@rickard-von-essen
Copy link
Collaborator

@gkuchta Sounds great, the problem have being getting in Glance support into gophercloud, see rackspace/gophercloud#213 (comment) and we probably need to migrate to gophercloud org before getting Glance support.

@mwhooker
Copy link
Contributor

We're planning to rewrite the shell-local post-processor, so this change is unnecessary.

Will also be happy to take a look at a PR of #2678 since it looks like the upstream changes have been merged.

@mwhooker mwhooker closed this Nov 17, 2016
@mwhooker
Copy link
Contributor

see also #4113 for possible glance support

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants