Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve not_null and null functions #83

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

bschaatsbergen
Copy link
Member

Fixes #76
Fixes #71

  • Currently, null checks whether the DynamicValue represents a literal null with no known type. This behavior conflicted with cross-object validation, where the type is known, and the underlying value needs to be checked to see if it evaluates to null. 9725ed fixes this.
  • Similarly, for not_null, we’re enabling cross-object validation by first determining if we’re dealing with a literal null value. If not, the underlying value is then checked to confirm whether it is null or not.

@bschaatsbergen bschaatsbergen requested a review from a team as a code owner January 3, 2025 14:56
@github-actions github-actions bot added new-function Pull requests that update or introduce new functions tests labels Jan 3, 2025
@bschaatsbergen bschaatsbergen removed the new-function Pull requests that update or introduce new functions label Jan 3, 2025
@github-actions github-actions bot added the new-function Pull requests that update or introduce new functions label Jan 3, 2025
@bschaatsbergen bschaatsbergen removed the new-function Pull requests that update or introduce new functions label Jan 3, 2025
@github-actions github-actions bot added github-actions Pull requests that update GitHub Actions code new-function Pull requests that update or introduce new functions labels Jan 3, 2025
@bschaatsbergen bschaatsbergen removed the new-function Pull requests that update or introduce new functions label Jan 3, 2025
@github-actions github-actions bot added the new-function Pull requests that update or introduce new functions label Jan 3, 2025
Unknown values could ultimately resolve to null or a valid value, so it’s best to avoid accepting them.
@bschaatsbergen bschaatsbergen merged commit e68d3ac into main Jan 10, 2025
10 of 11 checks passed
@bschaatsbergen bschaatsbergen deleted the b/fix-null-functions branch January 10, 2025 16:28
@bschaatsbergen bschaatsbergen added bug Something isn't working and removed new-function Pull requests that update or introduce new functions labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github-actions Pull requests that update GitHub Actions code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null is not equal to null provider::assert::null() not behaving as expected
2 participants