Skip to content

Commit

Permalink
Merge pull request #40047 from hashicorp/f-taxsettings
Browse files Browse the repository at this point in the history
feat: new service `taxsettings`
  • Loading branch information
YakDriver authored Nov 11, 2024
2 parents b46b42d + 7083b0d commit 7a8669e
Show file tree
Hide file tree
Showing 23 changed files with 962 additions and 91 deletions.
19 changes: 19 additions & 0 deletions .ci/.semgrep-service-name0.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4296,3 +4296,22 @@ rules:
patterns:
- pattern-regex: "(?i)ConfigService"
severity: WARNING
- id: connect-in-func-name
languages:
- go
message: Do not use "Connect" in func name inside connect package
paths:
include:
- internal/service/connect
exclude:
- internal/service/connect/list_pages_gen.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Connect"
- pattern-not-regex: .*uickConnect.*
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
48 changes: 29 additions & 19 deletions .ci/.semgrep-service-name1.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: connect-in-func-name
languages:
- go
message: Do not use "Connect" in func name inside connect package
paths:
include:
- internal/service/connect
exclude:
- internal/service/connect/list_pages_gen.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Connect"
- pattern-not-regex: .*uickConnect.*
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: connect-in-test-name
languages:
- go
Expand Down Expand Up @@ -4295,3 +4276,32 @@ rules:
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: iotanalytics-in-test-name
languages:
- go
message: Include "IoTAnalytics" in test name
paths:
include:
- internal/service/iotanalytics/*_test.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccIoTAnalytics"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: iotanalytics-in-const-name
languages:
- go
message: Do not use "IoTAnalytics" in const name inside iotanalytics package
paths:
include:
- internal/service/iotanalytics
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoTAnalytics"
severity: WARNING
72 changes: 43 additions & 29 deletions .ci/.semgrep-service-name2.yml
Original file line number Diff line number Diff line change
@@ -1,34 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: iotanalytics-in-test-name
languages:
- go
message: Include "IoTAnalytics" in test name
paths:
include:
- internal/service/iotanalytics/*_test.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccIoTAnalytics"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: iotanalytics-in-const-name
languages:
- go
message: Do not use "IoTAnalytics" in const name inside iotanalytics package
paths:
include:
- internal/service/iotanalytics
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)IoTAnalytics"
severity: WARNING
- id: iotanalytics-in-var-name
languages:
- go
Expand Down Expand Up @@ -4294,3 +4265,46 @@ rules:
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: redshift-in-test-name
languages:
- go
message: Include "Redshift" in test name
paths:
include:
- internal/service/redshift/*_test.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccRedshift"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: redshift-in-const-name
languages:
- go
message: Do not use "Redshift" in const name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshift-in-var-name
languages:
- go
message: Do not use "Redshift" in var name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
104 changes: 61 additions & 43 deletions .ci/.semgrep-service-name3.yml
Original file line number Diff line number Diff line change
@@ -1,48 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: redshift-in-test-name
languages:
- go
message: Include "Redshift" in test name
paths:
include:
- internal/service/redshift/*_test.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccRedshift"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: redshift-in-const-name
languages:
- go
message: Do not use "Redshift" in const name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshift-in-var-name
languages:
- go
message: Do not use "Redshift" in var name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshiftdata-in-func-name
languages:
- go
Expand Down Expand Up @@ -3293,6 +3250,67 @@ rules:
patterns:
- pattern-regex: "(?i)Synthetics"
severity: WARNING
- id: taxsettings-in-func-name
languages:
- go
message: Do not use "TaxSettings" in func name inside taxsettings package
paths:
include:
- internal/service/taxsettings
exclude:
- internal/service/taxsettings/list_pages_gen.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)TaxSettings"
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
- id: taxsettings-in-test-name
languages:
- go
message: Include "TaxSettings" in test name
paths:
include:
- internal/service/taxsettings/*_test.go
patterns:
- pattern: func $NAME( ... )
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccTaxSettings"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: taxsettings-in-const-name
languages:
- go
message: Do not use "TaxSettings" in const name inside taxsettings package
paths:
include:
- internal/service/taxsettings
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)TaxSettings"
severity: WARNING
- id: taxsettings-in-var-name
languages:
- go
message: Do not use "TaxSettings" in var name inside taxsettings package
paths:
include:
- internal/service/taxsettings
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)TaxSettings"
severity: WARNING
- id: timestreaminfluxdb-in-func-name
languages:
- go
Expand Down
2 changes: 2 additions & 0 deletions .github/labeler-issue-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,8 @@ service/swf:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_swf_'
service/synthetics:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_synthetics_'
service/taxsettings:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_taxsettings_'
service/textract:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_textract_'
service/timestreaminfluxdb:
Expand Down
6 changes: 6 additions & 0 deletions .github/labeler-pr-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2130,6 +2130,12 @@ service/synthetics:
- any-glob-to-any-file:
- 'internal/service/synthetics/**/*'
- 'website/**/synthetics_*'
service/taxsettings:
- any:
- changed-files:
- any-glob-to-any-file:
- 'internal/service/taxsettings/**/*'
- 'website/**/taxsettings_*'
service/textract:
- any:
- changed-files:
Expand Down
1 change: 1 addition & 0 deletions .teamcity/components/generated/services_all.kt
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ val services = mapOf(
"sts" to ServiceSpec("STS (Security Token)"),
"swf" to ServiceSpec("SWF (Simple Workflow)"),
"synthetics" to ServiceSpec("CloudWatch Synthetics", parallelismOverride = 10),
"taxsettings" to ServiceSpec("Tax Settings"),
"timestreaminfluxdb" to ServiceSpec("Timestream for InfluxDB", vpcLock = true, parallelismOverride = 3),
"timestreamwrite" to ServiceSpec("Timestream Write"),
"transcribe" to ServiceSpec("Transcribe"),
Expand Down
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/sts v1.32.4
github.com/aws/aws-sdk-go-v2/service/swf v1.27.4
github.com/aws/aws-sdk-go-v2/service/synthetics v1.29.4
github.com/aws/aws-sdk-go-v2/service/taxsettings v1.6.1
github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb v1.6.4
github.com/aws/aws-sdk-go-v2/service/timestreamwrite v1.29.4
github.com/aws/aws-sdk-go-v2/service/transcribe v1.41.4
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,8 @@ github.com/aws/aws-sdk-go-v2/service/swf v1.27.4 h1:lmYFiiZ+VCGgqt2d1xHSfp0SN7kD
github.com/aws/aws-sdk-go-v2/service/swf v1.27.4/go.mod h1:7Is8HtyC+vQskJFxErP7YoF/Zu6/FeQ7w8DHbyqx0Hk=
github.com/aws/aws-sdk-go-v2/service/synthetics v1.29.4 h1:LbOEGGiQv21rDS5uG+6accj80J0Ge7f6vKNvXaPyhOc=
github.com/aws/aws-sdk-go-v2/service/synthetics v1.29.4/go.mod h1:h/0XMdglPF+MHuq0zLeN9SCedbW0CJ4/5T/ggtDs+s0=
github.com/aws/aws-sdk-go-v2/service/taxsettings v1.6.1 h1:kper8FCLg9zRFT3/ez1/XwDKdeEfo7nebvBmZOZn37U=
github.com/aws/aws-sdk-go-v2/service/taxsettings v1.6.1/go.mod h1:tmVIxtzE4zvoK4LaWFOqeAUl1oZmR3SiT42gfmoveWY=
github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb v1.6.4 h1:p23Zsb1kHKA6lZsVTXkUC67v0MyMtEwnFsFBA2/M3TE=
github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb v1.6.4/go.mod h1:tFPhAm5lWLaxKyZ8kC91+t1DtNf2wfxK8mxAkc0psHU=
github.com/aws/aws-sdk-go-v2/service/timestreamwrite v1.29.4 h1:0+lRed/3INQCDdfhtw3kBv1P2ZNNxokoXSRALp/Vhhg=
Expand Down
1 change: 1 addition & 0 deletions infrastructure/repository/labels-service.tf
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ variable "service_labels" {
"support",
"swf",
"synthetics",
"taxsettings",
"textract",
"timestreaminfluxdb",
"timestreamquery",
Expand Down
5 changes: 5 additions & 0 deletions internal/conns/awsclient_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions internal/provider/fwprovider/provider_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions internal/provider/provider_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/provider/service_packages_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 7a8669e

Please sign in to comment.