Failing test(s): TestAccGKEHubFeatureMembership_gkehubFeatureAcm* #14591

megan07 · 2023-05-12T16:53:31Z

Failure rates

100% since 2023-05-10

Impacted tests

TestAccGKEHubFeatureMembership_gkehubFeatureAcmAllFields
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci

Affected Resource(s)

google_gke_hub_feature_membership

Nightly build test history

Link

Message(s)

Step 1/6 error: Error running apply: exit status 1
Error: Error creating FeatureMembership: googleapi: Error 400: InvalidValueError for field version: unsupported ACM version 1.12.0 for Membership projects/*/locations/global/memberships/tf-test14c0y4ft10g, supported versions are 1.13.0, 1.13.1, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.15.0
with google_gke_hub_feature_membership.feature_member,
on terraform_plugin_test.tf line 104, in resource "google_gke_hub_feature_membership" "feature_member":
104: resource "google_gke_hub_feature_membership" "feature_member" {

As of July 2023:

------- Stdout: -------
=== RUN   TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
=== PAUSE TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
=== CONT  TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
    vcr_utils.go:152: Step 5/8 error: After applying this test step, the plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_gke_hub_feature_membership.feature_member_2 will be updated in-place
          ~ resource "google_gke_hub_feature_membership" "feature_member_2" {
                id         = "projects/tf-test-gkehubdr4wbtvx6r/locations/global/features/configmanagement/membershipId/tf-test2dr4wbtvx6r"
                # (4 unchanged attributes hidden)
              ~ configmanagement {
                    # (1 unchanged attribute hidden)
                  ~ policy_controller {
                      ~ exemptable_namespaces      = [
                          - "1234",
                            "different",
                          + "1234",
                        ]
                        # (6 unchanged attributes hidden)
                        # (1 unchanged block hidden)
                    }
                    # (2 unchanged blocks hidden)
                }
            }
        Plan: 0 to add, 1 to change, 0 to destroy.
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        Error: Error deleting FeatureMembership: googleapi: Error 409: unable to queue the operation
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.ResourceInfo",
            "resourceName": "projects/tf-test-gkehubdr4wbtvx6r/locations/global/features/configmanagement"
          }
        ]
--- FAIL: TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate (832.27s)
FAIL

The text was updated successfully, but these errors were encountered:

melinath · 2023-05-26T21:19:55Z

b/284514917

SarahFrench · 2023-07-07T19:42:58Z

Updated the description with a new error that's affecting those tests

sahsagar-google · 2024-01-23T05:04:18Z

Is the error only related to the order of the returned fields?

melinath · 2024-01-23T17:38:34Z

yes - our preference in cases like this is to use a diff suppress function (diff_suppress_func in MMv1) to ignore diffs related to ordering (by sorting the lists and seeing if they end up the same, for example). The diff suppress will be run against the whole list and also against each element in the list, so you'd need to make sure that it's a no-op if it receives a string rather than a slice.

melinath · 2024-01-26T19:43:25Z

Slight correction after further discussion - rather than a diff suppress, it would be great to use a custom flattener that makes the order of values in state match the order in the configuration. That will suppress the diff and also make cleaner diffs if the list is changed in the future.

SarahFrench · 2024-02-07T11:36:43Z

New failure here:

    vcr_utils.go:152: Step 5/8 error: After applying this test step, the plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_gke_hub_feature_membership.feature_member will be updated in-place
          ~ resource "google_gke_hub_feature_membership" "feature_member" {
                id         = "projects/tf-test-gkehubvxugwj213m/locations/global/features/configmanagement/membershipId/tf-test1vxugwj213m"
                # (4 unchanged attributes hidden)
              ~ configmanagement {
                    # (1 unchanged attribute hidden)
                  - policy_controller {
                      - audit_interval_seconds     = "100" -> null
                      - enabled                    = true -> null
                      - exemptable_namespaces      = [
                          - "onetwothree",
                          - "fourfive",
                        ] -> null
                      - log_denies_enabled         = true -> null
                      - mutation_enabled           = false -> null
                      - referential_rules_enabled  = true -> null
                      - template_library_installed = true -> null
                      - monitoring {
                          - backends = [
                              - "PROMETHEUS",
                              - "CLOUD_MONITORING",
                            ] -> null
                        }
                    }
                    # (1 unchanged block hidden)
                }
            }
        Plan: 0 to add, 1 to change, 0 to destroy.
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        Error: Error deleting FeatureMembership: googleapi: Error 409: unable to queue the operation
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.ResourceInfo",
            "resourceName": "projects/tf-test-gkehubvxugwj213m/locations/global/features/configmanagement"
          }
        ]
--- FAIL: TestAccGKEHubFeatureMembership_gkehubFeatureAcmAllFields (575.53s)
FAIL

melinath · 2024-04-25T16:05:56Z

@sahsagar-google we've now added reusable functions that handle the main logic of the custom flattener we'd want in this case: https://googlecloudplatform.github.io/magic-modules/develop/permadiff/#list-order

melinath · 2024-04-25T16:06:49Z

although the error message has changed significantly 🤔

melinath · 2024-09-03T22:54:34Z

TestAccGKEHubFeatureMembership_gkehubFeatureAcmAllFields is no longer failing in this way
TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci is no longer failing in this way
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate is failing at (almost) 100% with a permadiff and problems cleaning up resources:

resource_gke_hub_feature_membership_test.go:33: Step 5/8 error: After applying this test step, the plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_gke_hub_feature_membership.feature_member_2 will be updated in-place
          ~ resource "google_gke_hub_feature_membership" "feature_member_2" {
                id                  = "projects/tf-test-gkehub1pofiidu84/locations/global/features/configmanagement/membershipId/tf-test21pofiidu84"
                # (5 unchanged attributes hidden)
              ~ configmanagement {
                    # (2 unchanged attributes hidden)
                  ~ policy_controller {
                      ~ audit_interval_seconds     = "10" -> "9"
                      ~ exemptable_namespaces      = [
                          ~ "asdf" -> "different",
                            "1234",
                        ]
                      ~ template_library_installed = true -> false
                        # (4 unchanged attributes hidden)
                        # (1 unchanged block hidden)
                    }
                    # (2 unchanged blocks hidden)
                }
            }
        Plan: 0 to add, 1 to change, 0 to destroy.
    testing_new.go:90: Error running post-test destroy, there may be dangling resources: exit status 1
        Error: Error waiting for Deleting Membership: Error code 13, message: an internal error has occurred
        Error: Error waiting for Deleting Membership: Error code 13, message: an internal error has occurred

The TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate never started passing consistently and the error is very similar so I'd be inclined to say it's not fixed yet.

roaks3 · 2024-09-30T21:01:02Z

TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci and TestAccGKEHubFeatureMembership_gkehubFeatureAcmAllFields now fail 100% with an error that looks like an API change:

=== RUN   TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci
=== PAUSE TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci
=== CONT  TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci
    resource_gke_hub_feature_membership_test.go:582: Step 1/6 error: Error running apply: exit status 1
        Error: Error creating FeatureMembership: googleapi: Error 400: InvalidValueError for field configSync.enabled: to install Config Sync, please set the field `configSync.enabled` to `true` explicitly; to uninstall Config Sync, please remove the Git or OCI configuration from Membership projects/821339993213/locations/global/memberships/tf-test1l3a286421j
          with google_gke_hub_feature_membership.feature_member,
          on terraform_plugin_test.tf line 104, in resource "google_gke_hub_feature_membership" "feature_member":
         104: resource "google_gke_hub_feature_membership" "feature_member" {
--- FAIL: TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci (889.88s)
FAIL

sahsagar-google · 2024-09-30T21:35:15Z

Asked Haiyan to take a look at this. Either she or I will provide an update soon. Thank you.

haiyanmeng · 2024-10-01T16:59:51Z

GoogleCloudPlatform/magic-modules#11880 should fix this.

zli82016 · 2024-10-02T16:24:09Z

TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci and TestAccGKEHubFeatureMembership_gkehubFeatureAcmAllFields now fail 100% with an error that looks like an API change:

=== RUN   TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci
=== PAUSE TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci
=== CONT  TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci
    resource_gke_hub_feature_membership_test.go:582: Step 1/6 error: Error running apply: exit status 1
        Error: Error creating FeatureMembership: googleapi: Error 400: InvalidValueError for field configSync.enabled: to install Config Sync, please set the field `configSync.enabled` to `true` explicitly; to uninstall Config Sync, please remove the Git or OCI configuration from Membership projects/821339993213/locations/global/memberships/tf-test1l3a286421j
          with google_gke_hub_feature_membership.feature_member,
          on terraform_plugin_test.tf line 104, in resource "google_gke_hub_feature_membership" "feature_member":
         104: resource "google_gke_hub_feature_membership" "feature_member" {
--- FAIL: TestAccGKEHubFeatureMembership_gkehubFeatureAcmOci (889.88s)
FAIL

GoogleCloudPlatform/magic-modules#11880 should fix these two tests.

zli82016 · 2024-10-10T21:56:33Z

The PR GoogleCloudPlatform/magic-modules#11964 will fix the permadiff in the field template_library_installed

zli82016 · 2024-10-10T21:58:13Z

Sometimes the test TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate fails with an internal error

------- Stdout: -------
=== RUN   TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
=== PAUSE TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
=== CONT  TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
    resource_gke_hub_feature_membership_test.go:33: Step 1/8 error: Error running apply: exit status 1
        Error: Error creating FeatureMembership: operation received error: error code "13", message: an internal error has occurred, details: []
         details: map[]
          with google_gke_hub_feature_membership.feature_member_2,
          on terraform_plugin_test.tf line 169, in resource "google_gke_hub_feature_membership" "feature_member_2":
         169: resource "google_gke_hub_feature_membership" "feature_member_2" {
--- FAIL: TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate (903.85s)
FAIL

I asked the service team for the exact error in b/284514917. Also, I will keep monitoring this test to see if the error happens again.

megan07 added the test-failure label May 12, 2023

rileykarson added service/gkehub test-failure-100 100% fail rate labels May 22, 2023

rileykarson added this to the Near-Term Goals milestone May 22, 2023

melinath added the forward/linked label May 26, 2023

melinath mentioned this issue Jan 26, 2024

Added document explaining best practices for resolving permadiffs GoogleCloudPlatform/magic-modules#9884

Merged

haiyanmeng mentioned this issue Oct 1, 2024

Set config_sync.enabled field to true to fix broken tests GoogleCloudPlatform/magic-modules#11880

Merged

rileykarson assigned zli82016 Oct 7, 2024

rileykarson modified the milestones: Near-Term Goals, Oct 2024 Test Burndown Oct 7, 2024

zli82016 mentioned this issue Oct 9, 2024

Fix TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate GoogleCloudPlatform/magic-modules#11964

Merged

modular-magician mentioned this issue Oct 10, 2024

Fix TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate #19818

Merged

modular-magician mentioned this issue Oct 10, 2024

Fix TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate hashicorp/terraform-provider-google-beta#8386

Merged

zli82016 mentioned this issue Oct 28, 2024

Remove policycontroller block from ACM configmanagement in gkehub_feature_membership tests GoogleCloudPlatform/magic-modules#12166

Merged

brettcurtis mentioned this issue Jan 11, 2025

Error waiting for Deleting Membership: Error code 9, message: cluster is currently running another operation. osinfra-io/google-cloud-kubernetes#313

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failing test(s): TestAccGKEHubFeatureMembership_gkehubFeatureAcm* #14591

Failing test(s): TestAccGKEHubFeatureMembership_gkehubFeatureAcm* #14591

megan07 commented May 12, 2023 •

edited by SarahFrench

Loading

melinath commented May 26, 2023

SarahFrench commented Jul 7, 2023

sahsagar-google commented Jan 23, 2024

melinath commented Jan 23, 2024

melinath commented Jan 26, 2024

SarahFrench commented Feb 7, 2024

melinath commented Apr 25, 2024

melinath commented Apr 25, 2024

melinath commented Sep 3, 2024 •

edited

Loading

roaks3 commented Sep 30, 2024

sahsagar-google commented Sep 30, 2024

haiyanmeng commented Oct 1, 2024

zli82016 commented Oct 2, 2024

zli82016 commented Oct 10, 2024

zli82016 commented Oct 10, 2024 •

edited

Loading

Failing test(s): TestAccGKEHubFeatureMembership_gkehubFeatureAcm* #14591

Failing test(s): TestAccGKEHubFeatureMembership_gkehubFeatureAcm* #14591

Comments

megan07 commented May 12, 2023 • edited by SarahFrench Loading

Failure rates

Impacted tests

Affected Resource(s)

Nightly build test history

Message(s)

melinath commented May 26, 2023

SarahFrench commented Jul 7, 2023

sahsagar-google commented Jan 23, 2024

melinath commented Jan 23, 2024

melinath commented Jan 26, 2024

SarahFrench commented Feb 7, 2024

melinath commented Apr 25, 2024

melinath commented Apr 25, 2024

melinath commented Sep 3, 2024 • edited Loading

roaks3 commented Sep 30, 2024

sahsagar-google commented Sep 30, 2024

haiyanmeng commented Oct 1, 2024

zli82016 commented Oct 2, 2024

zli82016 commented Oct 10, 2024

zli82016 commented Oct 10, 2024 • edited Loading

megan07 commented May 12, 2023 •

edited by SarahFrench

Loading

melinath commented Sep 3, 2024 •

edited

Loading

zli82016 commented Oct 10, 2024 •

edited

Loading