-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'soft_delete_policy' to 'google_storage_bucket' resource #18395
Conversation
…e policy on 'google_storage_bucket' resource. (#10171) (#17624) [upstream:3b9c61bd50c271e769a6cb81dbd28d5ba7512c15] Signed-off-by: Modular Magician <[email protected]>
…#9034) (#15924) Signed-off-by: Modular Magician <[email protected]>
** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you! |
Just commenting on branch mechanics prior to review. I've confirmed |
I run the tests in Teamcity for the affected services. If we prefer run test for the whole provider, feel free to let me know. |
Given we're doing an API client upgrade I think we should run the full suite. Let's do that post-merge but before pushing the release tag, though, just to make sure we're testing what we release 1:1 |
Release 4.85.0 is based on 4.84.0 and no diffs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, same comment as hashicorp/terraform-provider-google-beta#7510 (review)
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Part of b/346407424
Backport of GoogleCloudPlatform/magic-modules#10171 in provider 5.22 based on the impact to customers of the new soft delete defaults, this will allow them to opt out.
Tests run on Teamcity:
storage, fwtransport