Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'soft_delete_policy' to 'google_storage_bucket' resource #18395

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

zli82016
Copy link
Collaborator

@zli82016 zli82016 commented Jun 11, 2024

Part of b/346407424

Backport of GoogleCloudPlatform/magic-modules#10171 in provider 5.22 based on the impact to customers of the new soft delete defaults, this will allow them to opt out.

  1. Cherry-picked the change to add 'soft_delete_policy' to 'google_storage_bucket' resource
  2. Upgrade go api client to the version that SoftDeletePolicy field is present
  3. Fixed other failed tests

Tests run on Teamcity:
storage, fwtransport

modular-magician and others added 4 commits June 10, 2024 12:38
Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@rileykarson
Copy link
Collaborator

rileykarson commented Jun 11, 2024

Just commenting on branch mechanics prior to review. I've confirmed release-4.85.0 branch is branched from the same commit as the v4.84.0 tag right now, and this PR will update both the changelog + code of the branch to what we intend to release.

@zli82016
Copy link
Collaborator Author

zli82016 commented Jun 11, 2024

I run the tests in Teamcity for the affected services. If we prefer run test for the whole provider, feel free to let me know.

@rileykarson
Copy link
Collaborator

Given we're doing an API client upgrade I think we should run the full suite. Let's do that post-merge but before pushing the release tag, though, just to make sure we're testing what we release 1:1

@zli82016 zli82016 changed the base branch from release-4.84.1 to release-4.85.0 June 11, 2024 17:59
@zli82016
Copy link
Collaborator Author

Release 4.85.0 is based on 4.84.0 and no diffs

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zli82016 zli82016 merged commit cc1bc4d into release-4.85.0 Jun 11, 2024
1 check passed
@zli82016 zli82016 deleted the release-4.84.1-changelog branch June 11, 2024 19:03
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants