Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace diffs on logging_sink exclusion filters #19481

Closed
wants to merge 1 commit into from

Conversation

lyoung-confluent
Copy link

The top-level filter resource already has OptionalSurroundingSpacesSuppress, but the filter on exclusions does not causing unnecessary diffs when there only difference is leading/trailing whitespace, common because of the use of HEREDOC on this attribute.

Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@github-actions github-actions bot requested a review from melinath September 13, 2024 23:07
@melinath
Copy link
Collaborator

Thanks for your contribution! This change will need to be made in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/logging/resource_logging_sink.go, which should be pretty a straightforward migration of the change you made.

@melinath melinath closed this Sep 16, 2024
@lyoung-confluent
Copy link
Author

Thanks @melinath, I've opened GoogleCloudPlatform/magic-modules#11900

Copy link

github-actions bot commented Nov 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants