Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TeamCity testing project for ephemeral resources feature branch, clean up imports #19768

Conversation

modular-magician
Copy link
Collaborator

Adding projects in our TeamCity environment for testing ephemeral resources

This project will:

  • Use a more recent Terraform binary version that contains the ephemeral feature
    • See EphemeralResourcesTfCoreVersion
  • Have builds only for services were we're adding ephemeral resources
  • Have builds that allow using the hashicorp and modular-magician owned repos (can test PRs pre-merge)
  • CRON triggers to schedule builds (that use the hashicorp repo) every night

Preview of the changes

Here is a test project where this PR's config is deployed: https://hashicorp.teamcity.com/project/TerraformProviders_TerraformProviderGoogleSarahCheckingEphemeralTesting?mode=builds

This is what the new addition to TeamCity will look like - we only need to test the resourcemanager package as all ephemeral resources we want to add are in that package:

Screenshot 2024-10-03 at 21 15 35

Here's a look at the trigger set on the builds using the HashiCorp-owned repos:

Screenshot 2024-10-03 at 21 18 53

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11847

…clean up imports (hashicorp#11847)

[upstream:5fe624fbd8ee962c88e0048b596c4a28ec742bf8]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 845a637 into hashicorp:main Oct 7, 2024
2 checks passed
Copy link

github-actions bot commented Nov 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
@modular-magician modular-magician deleted the downstream-pr-5fe624fbd8ee962c88e0048b596c4a28ec742bf8 branch November 17, 2024 01:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant