Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance tests for request_timeout #19943

Conversation

modular-magician
Copy link
Collaborator

This PR adds acceptance tests for usage of request_timeout that demonstrate:

  • how the provider behaves when provider configuration arguments come from different sources ( config vs ENVs)
    • There are no ENVs for request_timeout
    • There are different default behaviours between SDK and PF
  • schema-level validation that's in place
    • Inputs must be parseable as a duration
      use cases: how does this argument impact the providers behaviour in plan/apply
    • I've implemented a test case where setting the timeout ridiculously low causes provisioning to fail.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11848

Co-authored-by: Mauricio Alvarez Leon <[email protected]>

[upstream:95e23d14332566da01ad5dacf2e043298f50d4cd]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 1984892 into hashicorp:main Oct 21, 2024
3 checks passed
@modular-magician modular-magician deleted the downstream-pr-95e23d14332566da01ad5dacf2e043298f50d4cd branch November 17, 2024 00:11
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant