Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance tests for how provider handles billing_project arguments #19991

Conversation

modular-magician
Copy link
Collaborator

This PR adds acceptance tests for usage of billing_project that demonstrate:

  • how the provider behaves when provider configuration arguments come from different sources ( config vs ENVs)
  • schema-level validation that's in place, e.g. handling of empty arrays
  • use cases: how does this argument impact the providers behaviour in plan/apply
    • I've tested the use of billing_project + user_project_override=false to show that billing_project has no impact then
    • I've tested the use of billing_project + user_project_override=true to show that billing_project does have impact then

NOTE: I added some usage tests for the PF provider, but they should be replaced in future because being limited to Firebase data sources to test the PF provider makes the test very awkward

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11610

…ents (hashicorp#11610)

[upstream:994ed958eaff29a174bb5761171b21322536e6dd]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit de0a050 into hashicorp:main Oct 23, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-994ed958eaff29a174bb5761171b21322536e6dd branch November 17, 2024 02:51
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant