Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate google_compute_firewall_policy_association resource from DCL to MMv1 #20214

Conversation

modular-magician
Copy link
Collaborator

Hello folks.
This PR is to move the Firewall Policy Association (google_compute_firewall_policy_association) resource from DCL to MMv1. And this PR includes:

  • Creation of the resource on MMv1.
  • Creation of the examples and tests.
  • Remove references to DCL resource.

Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_firewall_policy_association` now uses MMv1 engine instead of DCL.

Derived from GoogleCloudPlatform/magic-modules#11358

…to MMv1 (hashicorp#11358)

Co-authored-by: Zhenhua Li <[email protected]>

[upstream:3850a583f7d4839598b5bd5e73bbb3163df398c8]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit c11a600 into hashicorp:main Nov 6, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-3850a583f7d4839598b5bd5e73bbb3163df398c8 branch November 17, 2024 00:54
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant