Add conditions attribute to kubernetes_nodes data source #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsomesan
reviewed
Nov 13, 2024
| @@ -33,6 +33,9 @@ func TestAccKubernetesDataSourceNodes_basic(t *testing.T) { | |||
| resource.TestCheckResourceAttrWith(dataSourceName, "nodes.0.status.0.capacity.memory", checkParsableQuantity), | |||
| resource.TestCheckResourceAttrSet(dataSourceName, "nodes.0.status.0.node_info.0.architecture"), | |||
| resource.TestCheckResourceAttrSet(dataSourceName, "nodes.0.status.0.addresses.0.address"), | |||
| resource.TestMatchResourceAttr(dataSourceName, "nodes.0.status.0.conditions.#", oneOrMore), | |||
| resource.TestCheckResourceAttrSet(dataSourceName, "nodes.0.status.0.conditions.0.type"), | |||
| resource.TestCheckResourceAttrSet(dataSourceName, "nodes.0.status.0.conditions.0.status"), | |||
There was a problem hiding this comment.
Is it not feasible to test for all the newly introduced attributes?
There was a problem hiding this comment.
I can certainly do that! Will update the test, to include the additional attributes 👍
alexsomesan
approved these changes
Nov 14, 2024
JaylonmcShan03
deleted the
add-node-conditions-to-kubernetes-nodes-data-source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2430
This PR introduces a new
conditionsattribute to thekubernetes_nodesdata source, which will provide detailed insights into each node's health and operational status.Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note