add support email address

[iishabakaev]

Same as #405, because PR not merged since 2018

Fix this problem #35

[hashicorp-cla-app]

All committers have signed the CLA.

[iishabakaev]

@austinvalle hello!

Sorry to bother you, could you review this PR, this?
Its will be great if provider support email address field in csr generation

[austinvalle]

Hey @iishabakaev 👋🏻 , thanks for submitting the PR and apologies for the delay in review!

I have left some specific code feedback on the PR as well as I have some general feedback that will need to be addressed before we can accept the change:

• This PR only updates the tls_cert_request schema to include this new field, however the underlying logic is also shared by tls_self_signed_cert.
  • I think we should adjust the tls_self_signed_cert schema as well to include this new email_address field so we can fully close Add support for email_addresses in tls_cert_request and tls_self_signed_cert resources #35
• This PR will need acceptance tests before we can merge it. This should just be updating the existing ones that test the subject and just verifying the data is properly set:
  • https://github.com/hashicorp/terraform-provider-tls/blob/10b2c5511703aab6de581d2e0fa6134fe64e12d6/internal/provider/resource_cert_request_test.go
  • https://github.com/hashicorp/terraform-provider-tls/blob/10b2c5511703aab6de581d2e0fa6134fe64e12d6/internal/provider/resource_self_signed_cert_test.go
• This PR will need a changelog, but I can also help with that once the PR is updated to address some of the feedback

[austinvalle]

Some general housekeeping things:

• You'll need to run the documentation generator to update the markdown docs: make generate
• Our CI acceptance tests won't run from a forked PR, so once you make the changes and test locally, I'll open a mirror PR to confirm the tests are all green ✅

[iishabakaev]

Updated PR based on all comments

For testing I had to tinker a bit, the standard function x509.ParseCertificate parses ExtraNames in raw, so I added the creation of email_address

[austinvalle]

Thanks for the updates @iishabakaev!

I've opened a mirror PR which we can eventually use to run the CI tests (I still need to manually move the changes/approve them 😄 )
#599

Currently I think the remaining items for this PR are:

• Run the doc generator locally to fix that diff in our CI
• Remove the changes to docs/cdktf
• Verify the tests are all green ✅

After that I can push a changelog and merge it.

[austinvalle]

Looks like there is a test failure in the PR, see comment in review.

Also you can run the tests locally by just running make testacc or just running with any go test command equivalent with the env variable TF_ACC=1

[austinvalle]

You won't be able to add this here since tests like TestAccResourceSelfSignedCert_UpgradeFromVersion3_4_0 also use this function, which tests migration from an older version of the provider that doesn't have the email_address attribute

https://github.com/hashicorp/terraform-provider-tls/actions/runs/12956793277/job/36143882711?pr=599

You can duplicate the config in TestResourceSelfSignedCert to just add email address there, or make it a parameter in this function, whichever you prefer