feature: instant_clone

[Anant99-sys]

Description

Implementation for instant clone functionality

• The Instant Clone technology is used to create powered-on virtual machines from the running state of another powered-on virtual machine.
• The result of an Instant Clone operation is a new virtual machine that is identical to the source virtual machine.
• With Instant Clone you can create new virtual machines from a controlled point in time.
  Instant cloning is very convenient for large-scale application deployments because it ensures memory efficiency and allows for creating numerous virtual machines on a single host.
• This functionality can be used for Creating a powered-on Instant Clone of a virtual machine.

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccResourceVSphereVirtualMachine_Instantclone"

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccResourceVSphereVirtualMachine_Instantclone -timeout 240m
?   	github.com/hashicorp/terraform-provider-vsphere	[no test files]
=== RUN   TestAccResourceVSphereVirtualMachine_Instantclone
--- PASS: TestAccResourceVSphereVirtualMachine_Instantclone (188.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	191.274s
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/administrationroles	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/clustercomputeresource	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/computeresource	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/contentlibrary	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/customattribute	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/datacenter	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/datastore	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/dvportgroup	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/envbrowse	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/folder	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/hostsystem	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/network	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/nsx	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/ovfdeploy	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/provider	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/resourcepool	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/spbm	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/storagepod	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/structure	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/testhelper	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/utils	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/vappcontainer	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/viapi	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/virtualdisk	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/virtualmachine	[no test files]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/vsansystem	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/virtualdevice	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/vmworkflow	[no test files]

...

Release Note

Release note for CHANGELOG:

Capability to Add Instant Clone for a Parent VM.

References

[hashicorp-cla]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

---

1 out of 2 committers have signed the CLA.

• Anant99-sys
• Anant Chopra

---

Anant Chopra seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[Anant99-sys]

Can the authorized users please review this so that PR be merged?

[markpeek]

@koikonom could you review and merge this change?

[markpeek]

@koikonom @aareet any timeframe to review and merge this change?

[redeux]

Thank you for your contribution to the vSphere provider. I've tagged this as a candidate for our next release. Please ensure that the all requirements, such as signing the Contributor License Agreement, are met. We will start planning for the next release soon, but will be unable to evaluate your PR until all requirements are met.

[Anant99-sys]

Thank you for your contribution to the vSphere provider. I've tagged this as a candidate for our next release. Please ensure that the all requirements, such as signing the Contributor License Agreement, are met. We will start planning for the next release soon, but will be unable to evaluate your PR until all requirements are met.

I have signed the CLA but it is still not updating

[redeux]

I have signed the CLA but it is still not updating

Please see the message from the hashicorp-cla bot above: #1371 (comment)

[Anant99-sys]

As you can see its not updating that i had signed the CLA. can you please help or help me rectify this?

[aareet]

@Anant99-sys if you look at your commit history, does the email address in the commit match the one you are providing to the CLA bot?

[mfilipiak-ccg]

Is there anything any of us can do to help this issue along? I had worked on a similar MR but stopped when I saw this one so far along. It'd be a shame to see the merge linger.

[Anant99-sys]

Is there anything any of us can do to help this issue along? I had worked on a similar MR but stopped when I saw this one so far along. It'd be a shame to see the merge linger.

@Anant99-sys if you look at your commit history, does the email address in the commit match the one you are providing to the CLA bot?

Actually, I cannot check commit history as I have lost the working directory (changed my laptop and was unable to get back up )where I was working with this code. So not able to respond to this message

[mfilipiak-ccg]

Bumping, since this seems dead in the water over the CLA.

Would love to have this feature merged in. Should somebody resubmit the patch so they can accept the CLA. I'm willing to help however necessary.

[tenthirtyam]

@Anant99-sys -

Given that this is blocked by the CLA issue, I suggest considering resubmitting the PR based on your fork/branch by recreating the changes and signing the commit?

Set your email on the feature branch based on the email that's signed the CLA and attached to your GitHub account):

git config user.email [email protected]

Sign-off in the commit description:

Signed-off-by: Anant Chopra <[email protected]>

Then submit the new PR for review.

Another possibility may be to allow a maintainer or delegate another contributor to submit the enhancement if the CLA issue can not be resolved.

Ryan

[Anant99-sys]

@Anant99-sys -

Given that this is blocked by the CLA issue, I suggest considering resubmitting the PR based on your fork/branch by recreating the changes and signing the commit?

Set your email on the feature branch based on the email that's signed the CLA and attached to your GitHub account):

git config user.email [email protected]

Sign-off in the commit description:

Signed-off-by: Anant Chopra <[email protected]>

Then submit the new PR for review.

Another possibility may be to allow a maintainer or delegate another contributor to submit the enhancement if the CLA issue can not be resolved.

Ryan

Thanks . I followed the steps and created the new PR for review. Please take a look at #1516 to help approve @mfilipiak-ccg

[tenthirtyam]

I suggest closing this PR since it’s replaced by #1516.

Ryan

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.