fix: reconfigure vm with multiple pci passthrough devices #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stoyan Zhelyazkov <[email protected]>
Signed-off-by: Stoyan Zhelyazkov <[email protected]>
github-actions
bot
added
provider
tenthirtyam
changed the title
Is there an issue that can track the need to refactor this area? |
tenthirtyam
approved these changes
Jul 5, 2024
iBrandyJackson
approved these changes
Jul 5, 2024
good idea, I just logged one |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Usually when we reconfigure VMs we set negative integers as keys for new devices. vCenter assigns actual keys after the reconfiguration task completes which we then read and reassign to our resource.
This was not the case with PCI passthrough devices. No key was being assigned which meant that every such device got a zero as its key (the default integer value). This is fine if you're adding a single device but if you try with more than one the API fails.
The fix is simple - we simply need to assign a unique negative integer as the device key just like we do for other device types.
Acceptance tests
I had to manually test this one since it requires dedicated devices on the underlying hardware.
There is an important disclaimer to be made here - adding PCI passthrough devices during VM creation does not work. It is does not work out of the box and this is not related to this change.
I am not making an attempt to resolve this problem with this PR as it requires a significant refactoring effort.
Release Note
resource/virtual_machine: Fixed virtual machine reconfiguration with multiple PCI passthrough devices.References
Closes #1688