Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused exprFunc #311

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Remove unused exprFunc #311

merged 1 commit into from
Jan 3, 2024

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Dec 22, 2023

Type was removed from hcl-lang in hashicorp/hcl-lang#354 and was unused anyway.

@dbanck dbanck self-assigned this Dec 22, 2023
@dbanck dbanck requested a review from a team as a code owner December 22, 2023 16:07
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it's unused type I'm assuming this actually does not depend on the upstream hcl-lang PR, or does it?

@dbanck dbanck force-pushed the c-remove-legacy-expressions branch from 59c50fe to fb40c32 Compare January 3, 2024 13:54
@dbanck
Copy link
Member Author

dbanck commented Jan 3, 2024

You're right, I removed the dependency bump.

I meant to say, that if we remove the types in hcl-lang, we need to merge this, as well.

@dbanck dbanck merged commit f5a142d into main Jan 3, 2024
5 checks passed
@dbanck dbanck deleted the c-remove-legacy-expressions branch January 3, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants