Add the Variable struct #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
radeksimko
reviewed
May 27, 2021
There was a problem hiding this comment.
This is a great start! 👍🏻
Aside from my in-line comment - I think that we can also leverage the new struct in the earlydecoder and add a test for the collection of variables there?
https://github.com/hashicorp/terraform-schema/blob/main/earlydecoder/decoder.go
Then you could raise a separate PR to terraform-ls which implements steps 3 and 4 of hashicorp/terraform-ls#50
and then finally carry on with the rest of hashicorp/terraform-ls#537
Nepomuceno
force-pushed
the
add-variable
branch
2 times, most recently
from
49b7c13 to
b43d158
Compare
radeksimko
approved these changes
May 27, 2021
|
I'm going to have #48 reviewed first and then once merged I'd like to revisit this PR, rebase it and see if we can introduce the |
Adding a struct to represent the variable block in the terraform files This will help in storing this values while parsing tf files.
radeksimko
reviewed
Jun 1, 2021
radeksimko
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a struct to represent the variable block in the terraform files
This will help in storing this values while parsing tf files.