Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for docs command #36149

Closed
wants to merge 3 commits into from

Conversation

ujjwal-ibm
Copy link

@ujjwal-ibm ujjwal-ibm commented Dec 2, 2024

Fixes #36148

Target Release

1.11.x

Draft CHANGELOG entry

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

% go test -v -run "^TestDocs"
=== RUN   TestDocsCommand_implements
--- PASS: TestDocsCommand_implements (0.00s)
=== RUN   TestDocs_basic
--- PASS: TestDocs_basic (0.00s)
=== RUN   TestDocs_resourceDoc
--- PASS: TestDocs_resourceDoc (0.00s)
=== RUN   TestDocs_searchKeyword
--- PASS: TestDocs_searchKeyword (0.00s)
=== RUN   TestDocs_invalidProvider
--- PASS: TestDocs_invalidProvider (0.00s)
=== RUN   TestDocs_missingDocs
--- PASS: TestDocs_missingDocs (0.00s)
=== RUN   TestDocs_invalidFlags
--- PASS: TestDocs_invalidFlags (0.01s)
PASS
ok      github.com/hashicorp/terraform/internal/command 1.407s

@ujjwal-ibm ujjwal-ibm requested a review from a team as a code owner December 2, 2024 18:24
Copy link

hashicorp-cla-app bot commented Dec 2, 2024

CLA assistant check
All committers have signed the CLA.

@crw
Copy link
Contributor

crw commented Dec 2, 2024

@ujjwal-ibm thanks for the pull request. Per the contribution guide, we prefer to discuss the solution before starting on implementation. That said, I'll raise this PR in triage to see if we can review it or get it on the schedule for review.

@crw crw added the enhancement label Dec 2, 2024
@ujjwal-ibm
Copy link
Author

@crw thanks for the reply, do share the feedback and review comments

@ujjwal-ibm
Copy link
Author

@crw any update ?

@crw
Copy link
Contributor

crw commented Jan 14, 2025

Hi @ujjwal-ibm, apologies I lost track of this one. Feedback from the team was that we would not merge a new command like this without significant product necessity, likely driven by the product management team. The feedback in triage was that this functionality would be better as an external tool, such as tfenv. Thanks very much for this submission, hopefully you get a chance to try continue this work as its own tool!

@crw crw closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for docs command which would get the documents for the provider
2 participants