stacks: allow unknown variables during apply operations #36311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
commented
Jan 13, 2025
|
|
||
| sort.SliceStable(applyDiags, diagnosticSortFunc(applyDiags)) | ||
| expectDiagnosticsForTest(t, applyDiags, | ||
| expectDiagnostic( | ||
| tfdiags.Error, | ||
| "Inconsistent value for input variable during apply", | ||
| "The value for non-ephemeral input variable \"input\" was set to a different value during apply than was set during plan. Only ephemeral input variables can change between the plan and apply phases."), | ||
| expectDiagnostic(tfdiags.Error, "Invalid inputs for component", "Invalid input variable definition object: attribute \"input\": string required."), |
There was a problem hiding this comment.
This is the extra diagnostic discussed in the description. This is the diagnostic that now prevents the bad component from actually applying.
| @@ -3110,16 +3117,14 @@ func TestApplyWithChangedInputValues(t *testing.T) { | |||
|
|
|||
| go Apply(ctx, &applyReq, &applyResp) | |||
| applyChanges, applyDiags := collectApplyOutput(applyChangesCh, diagsCh) | |||
| if len(applyDiags) != 1 { | |||
There was a problem hiding this comment.
this was redundant, we also check the diagnostics on line 3121, so doing it twice was pointless.
|
Jira ticket created by Sarah: https://hashicorp.atlassian.net/browse/TF-23317 |
nfagerlund
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
I think this logic checks out, and the test case is an accurate reduction of what I understood about how to reproduce the bug we saw.
As mentioned in #36310, I tested a combination of the two PRs, and was able to fully destroy a stack that errored during apply on the first destroy attempt.
liamcervante
added
the
no-changelog-needed
dsa0x
approved these changes
Jan 17, 2025
jbardin
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assumption was made in Stacks that unknown variables should not be available at all during apply operations. This assumption was not true - we can have unknown values during refresh, destroy and deferred operations.
This PR removes the part of Stacks that was skipping components that found unknown variables - this was causing endless loops of undestroyable configuration in practice.
This PR also updates the part where variables are loaded for components to allow a specific error to result in a completely unapplyable component. This is the case where a variable has changed between the plan and apply operations. Previously, this was resulting in an unknown value that was just leaving the component to be skipped. Now, we aren't skipping that component anymore so we need to find a way to make that error stronger. This does result in an extra diagnostic being written in this specific error case, but as this error represents a problem in Terraform we should hopefully never see this case in practice.
A side effect of this, is that components with unknown variables now return slightly more complete state updates which has resulted in several tests being updated.