Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code owners #613

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Update code owners #613

merged 1 commit into from
Mar 20, 2024

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Mar 19, 2024

  • ignore scratch dir

@benashz
Update code owners
09662eb 
- ignore scratch dir
@benashz benashz requested review from a team and tvoran March 19, 2024 16:09
tomhjp
tomhjp reviewed Mar 19, 2024
View reviewed changes
CODEOWNERS
@@ -1,4 +1 @@
# release configuration

/.release/ @hashicorp/github-secure-vault-ecosystem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we can delete these? I think they're CRT-related, but I forget why they're needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project seems to be using CRT, so I don't think these are still necessary. Other CRT enabled projects do not have them. I tagged @tvoran since he might have a better insight on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomhjp confirmed with rel-eng we don't need to include them as code owners.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah rel-eng removed themselves from CODEOWNERS here a few months ago, and I don't know of any reason we need to keep github-secure-vault-ecosystem. hashicorp/vault-ecosystem seems like a better fit for now.

@benashz benashz requested a review from sarahethompson March 19, 2024 16:16
@benashz
Copy link
Contributor Author

benashz commented Mar 19, 2024

@sarahethompson wanted to check to see if we still need these code owner directives?

@benashz benashz requested review from tomhjp and removed request for sarahethompson March 19, 2024 20:07
swenson
swenson approved these changes Mar 20, 2024
View reviewed changes
Copy link

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benashz
Copy link
Contributor Author

benashz commented Mar 20, 2024

Thanks!

@benashz benashz merged commit 84287a2 into main Mar 20, 2024
19 checks passed
@benashz benashz deleted the update-codeowners branch March 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swenson swenson swenson approved these changes

@tvoran tvoran Awaiting requested review from tvoran

@tomhjp tomhjp Awaiting requested review from tomhjp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benashz @swenson @tvoran @tomhjp