Backport of UI: Fix enabling replication capabilities bug into releas…

…e/1.17.x (#28375)

* backport of commit 49b46ea

* add capabilities service (from #28168)

* fix failing ent test

---------

Co-authored-by: claire bontempo <[email protected]>
Co-authored-by: Chelsea Shaw <[email protected]>

ui/lib/replication/addon/components/enable-replication-form.hbs

@@ -29,7 +29,7 @@
       {{/if}}
     </div>
     {{#if (eq this.data.mode "primary")}}
-      {{#if @canEnablePrimary}}
+      {{#if this.canEnablePrimary}}
         <div class="field">
           <label for="primary_cluster_addr" class="is-label">
             Primary cluster address
@@ -55,7 +55,7 @@
         </p>
       {{/if}}
     {{else}}
-      {{#if @canEnableSecondary}}
+      {{#if this.canEnableSecondary}}
         {{#if (and (eq @replicationMode "dr") this.performanceReplicationEnabled (has-feature "Performance Replication"))}}
           <div>
             <ToggleButton
@@ -169,7 +169,9 @@
     {{/if}}
   </div>
   {{#if
-    (or (and (eq this.data.mode "primary") @canEnablePrimary) (and (eq this.data.mode "secondary") @canEnableSecondary))
+    (or
+      (and (eq this.data.mode "primary") this.canEnablePrimary) (and (eq this.data.mode "secondary") this.canEnableSecondary)
+    )
   }}
     <div class="field is-grouped box is-fullwidth is-bottomless">
       <Hds::Button @text="Enable Replication" type="submit" disabled={{this.disallowEnable}} data-test-replication-enable />

ui/lib/replication/addon/components/enable-replication-form.js

@@ -22,8 +22,10 @@ import { waitFor } from '@ember/test-waiters';
  * ```js
  * <EnableReplicationForm @replicationMode="dr" @canEnablePrimary={{true}} @canEnableSecondary={{false}} @performanceReplicationDisabled={{false}} @onSuccess={{this.reloadCluster}} />
  *    @param {string} replicationMode - should be one of "dr" or "performance"
- *    @param {boolean} canEnablePrimary - if the capabilities allow the user to enable a primary cluster
- *    @param {boolean} canEnableSecondary - if the capabilities allow the user to enable a secondary cluster
+ *    @param {boolean} canEnablePrimaryDr - if the capabilities allow the user to enable a DR primary cluster
+ *    @param {boolean} canEnablePrimaryPerformance - if the capabilities allow the user to enable a Performance primary cluster
+ *    @param {boolean} canEnableSecondaryDr - if the capabilities allow the user to enable a DR secondary cluster
+ *    @param {boolean} canEnableSecondaryPerformance - if the capabilities allow the user to enable a Performance secondary cluster
  *    @param {boolean} performanceMode - should be "primary", "secondary", or "disabled". If enabled, form will show a warning when attempting to enable DR secondary
  *    @param {Promise} onSuccess - (optional) callback called after successful replication enablement. Must be a promise.
  *    @param {boolean} doTransition - (optional) if provided, passed to onSuccess callback to determine if a transition should be done
@@ -58,6 +60,22 @@ export default class EnableReplicationFormComponent extends Component {
     return true;
   }
 
+  get canEnablePrimary() {
+    const { replicationMode, canEnablePrimaryDr, canEnablePrimaryPerformance } = this.args;
+    if (replicationMode === 'dr') {
+      return canEnablePrimaryDr !== false;
+    }
+    return canEnablePrimaryPerformance !== false;
+  }
+
+  get canEnableSecondary() {
+    const { replicationMode, canEnableSecondaryDr, canEnableSecondaryPerformance } = this.args;
+    if (replicationMode === 'dr') {
+      return canEnableSecondaryDr !== false;
+    }
+    return canEnableSecondaryPerformance !== false;
+  }
+
   async onSuccess(resp, clusterMode) {
     // clear form
     this.data.reset();

ui/lib/replication/addon/components/page/mode-index.hbs

@@ -45,8 +45,10 @@
   </div>
   <EnableReplicationForm
     @replicationMode={{@replicationMode}}
-    @canEnablePrimary={{@cluster.canEnablePrimary}}
-    @canEnableSecondary={{@cluster.canEnableSecondary}}
+    @canEnablePrimaryDr={{@cluster.canEnablePrimaryDr}}
+    @canEnablePrimaryPerformance={{@cluster.canEnablePrimaryPerformance}}
+    @canEnableSecondaryDr={{@cluster.canEnableSecondaryDr}}
+    @canEnableSecondaryPerformance={{@cluster.canEnableSecondaryPerformance}}
     @performanceReplicationDisabled={{@cluster.performance.replicationDisabled}}
     @performanceMode={{if @cluster.performance.replicationDisabled "disabled" @cluster.performance.modeForUrl}}
     @onSuccess={{@onEnableSuccess}}

ui/lib/replication/addon/routes/application.js

@@ -31,19 +31,34 @@ export default Route.extend(ClusterRoute, {
 
   afterModel(model) {
     return hash({
-      canEnablePrimary: this.store
-        .findRecord('capabilities', 'sys/replication/primary/enable')
+      canEnablePrimaryPerformance: this.store
+        .findRecord('capabilities', 'sys/replication/performance/primary/enable')
         .then((c) => c.canUpdate),
-      canEnableSecondary: this.store
-        .findRecord('capabilities', 'sys/replication/secondary/enable')
+      canEnableSecondaryPerformance: this.store
+        .findRecord('capabilities', 'sys/replication/performance/secondary/enable')
         .then((c) => c.canUpdate),
-    }).then(({ canEnablePrimary, canEnableSecondary }) => {
-      setProperties(model, {
-        canEnablePrimary,
-        canEnableSecondary,
-      });
-      return model;
-    });
+      canEnablePrimaryDr: this.store
+        .findRecord('capabilities', 'sys/replication/dr/primary/enable')
+        .then((c) => c.canUpdate),
+      canEnableSecondaryDr: this.store
+        .findRecord('capabilities', 'sys/replication/dr/secondary/enable')
+        .then((c) => c.canUpdate),
+    }).then(
+      ({
+        canEnablePrimaryPerformance,
+        canEnableSecondaryPerformance,
+        canEnablePrimaryDr,
+        canEnableSecondaryDr,
+      }) => {
+        setProperties(model, {
+          canEnablePrimaryPerformance,
+          canEnableSecondaryPerformance,
+          canEnablePrimaryDr,
+          canEnableSecondaryDr,
+        });
+        return model;
+      }
+    );
   },
   actions: {
     refresh() {

ui/tests/integration/components/enable-replication-form-test.js

@@ -44,8 +44,10 @@ module('Integration | Component | enable-replication-form', function (hooks) {
       await render(
         hbs`<EnableReplicationForm
       @replicationMode={{this.replicationMode}}
-      @canEnablePrimary={{true}}
-      @canEnableSecondary={{true}}
+      @canEnablePrimaryDr={{true}}
+      @canEnablePrimaryPerformance={{true}}
+      @canEnableSecondaryDr={{true}}
+      @canEnableSecondaryPerformance={{true}}
       @performanceMode="disabled"
     />`,
         this.context
@@ -74,8 +76,10 @@ module('Integration | Component | enable-replication-form', function (hooks) {
       await render(
         hbs`<EnableReplicationForm
           @replicationMode={{this.replicationMode}}
-          @canEnablePrimary={{false}}
-          @canEnableSecondary={{false}}
+          @canEnablePrimaryDr={{false}}
+          @canEnablePrimaryPerformance={{false}}
+          @canEnableSecondaryDr={{false}}
+          @canEnableSecondaryPerformance={{false}}
           @performanceMode="disabled"
         />`,
         this.context
@@ -105,8 +109,10 @@ module('Integration | Component | enable-replication-form', function (hooks) {
     await render(
       hbs`<EnableReplicationForm
         @replicationMode={{this.replicationMode}}
-        @canEnablePrimary={{true}}
-        @canEnableSecondary={{true}}
+        @canEnablePrimaryDr={{true}}
+        @canEnablePrimaryPerformance={{true}}
+        @canEnableSecondaryDr={{true}}
+        @canEnableSecondaryPerformance={{true}}
         @performanceMode={{this.performanceMode}}
       />`,
       this.context
@@ -146,8 +152,10 @@ module('Integration | Component | enable-replication-form', function (hooks) {
       await render(
         hbs`<EnableReplicationForm
           @replicationMode="performance"
-          @canEnablePrimary={{true}}
-          @canEnableSecondary={{true}}
+          @canEnablePrimaryDr={{true}}
+          @canEnablePrimaryPerformance={{true}}
+          @canEnableSecondaryDr={{true}}
+          @canEnableSecondaryPerformance={{true}}
           @performanceMode="disabled"
         />`,
         this.context
@@ -178,8 +186,10 @@ module('Integration | Component | enable-replication-form', function (hooks) {
         await render(
           hbs`<EnableReplicationForm
             @replicationMode={{this.replicationMode}}
-            @canEnablePrimary={{true}}
-            @canEnableSecondary={{true}}
+            @canEnablePrimaryDr={{true}}
+            @canEnablePrimaryPerformance={{true}}
+            @canEnableSecondaryDr={{true}}
+            @canEnableSecondaryPerformance={{true}}
             @performanceMode="disabled"
             @onSuccess={{this.onSuccess}}
             @doTransition={{false}}
@@ -217,8 +227,10 @@ module('Integration | Component | enable-replication-form', function (hooks) {
         await render(
           hbs`<EnableReplicationForm
           @replicationMode={{this.replicationMode}}
-            @canEnablePrimary={{true}}
-            @canEnableSecondary={{true}}
+            @canEnablePrimaryDr={{true}}
+            @canEnablePrimaryPerformance={{true}}
+            @canEnableSecondaryDr={{true}}
+            @canEnableSecondaryPerformance={{true}}
             @performanceMode="disabled"
             @onSuccess={{this.onSuccess}}
             @doTransition={{true}}
@@ -258,8 +270,10 @@ module('Integration | Component | enable-replication-form', function (hooks) {
         await render(
           hbs`<EnableReplicationForm
             @replicationMode={{this.replicationMode}}
-            @canEnablePrimary={{true}}
-            @canEnableSecondary={{true}}
+            @canEnablePrimaryDr={{true}}
+            @canEnablePrimaryPerformance={{true}}
+            @canEnableSecondaryDr={{true}}
+            @canEnableSecondaryPerformance={{true}}
             @performanceMode="disabled"
             @onSuccess={{this.onSuccess}}
           />`,
@@ -277,8 +291,10 @@ module('Integration | Component | enable-replication-form', function (hooks) {
         await render(
           hbs`<EnableReplicationForm
           @replicationMode={{this.replicationMode}}
-            @canEnablePrimary={{true}}
-            @canEnableSecondary={{true}}
+            @canEnablePrimaryDr={{true}}
+            @canEnablePrimaryPerformance={{true}}
+            @canEnableSecondaryDr={{true}}
+            @canEnableSecondaryPerformance={{true}}
             @performanceMode="disabled"
             @onSuccess={{this.onSuccess}}
           />`,