Add use_csr_serial_number option to PKI role
#25709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25708
Currently on
/pki/sign/:name, the other fields that can have their values taken from the CSR, namely SANs andcommon_name, have ause_csr_*option to control whether or not they take their values from the CSR.serial_numberis also taken from the CN in the CSR, but there is currently no way to ignore theserial_numberin the CSR.This PR adds the
use_csr_serial_numberPKI role parameter which controls whether or not theserial_numberis taken from the CSR. It defaults to true so that the previous behaviour is kept. If aserial_numberis provided in the JSON data, then that takes precedence over the value in the CSR.