-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAULT-32411: upgrade go jose dependency in auth plugins #28947
VAULT-32411: upgrade go jose dependency in auth plugins #28947
Conversation
Build Results: |
CI Results: failed ❌ |
@@ -2,4 +2,7 @@ module github.com/hashicorp/vault/api/auth/approle | |||
|
|||
go 1.16 | |||
|
|||
require github.com/hashicorp/vault/api v1.12.0 | |||
require ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to make this require block list out all of the indirect dependencies? It would help a lot for future maintainability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment for the other go.mods :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, will do!
I tried running go mod tidy
but I do not see go mod files changed. I ran go get -u ./...
which changed the go.mod file to list all indirect dependencies but it also upgraded them. The command go get ./...
which is supposed to just list the indirect dependencies without upgrading them is making no changes inside the go mod files. Are these the commands you were also thinking of to list them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some colour here: https://go.dev/ref/mod#go-mod-file-require
If we need to list them out one at a time, that'd still be a good thing to do -- but there's probably a better way (regenerating it from scratch?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a look now, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found the way Violet! It requires go mod version to be at least 17 but i think it is fine? Since this is the wrong repo we are making changes against, I will create a new PR on vault enterprise repo and tag you there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! And yeah, that works great :)
Description
What does this PR do?
Upgrades the github.com/go-jose/go-jose/v3 dependency in auth plugins to the latest version.
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.