Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decryption of raft bootstrap challenge in multi-seal scenarios #29117

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

victorr
Copy link
Contributor

@victorr victorr commented Dec 6, 2024

Description

Fix decryption of raft bootstrap challenge in multi-seal scenarios (Vault Enterprise).

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@victorr victorr added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Dec 6, 2024
@victorr victorr added this to the 1.18.3 milestone Dec 6, 2024
@victorr victorr self-assigned this Dec 6, 2024
@victorr victorr requested a review from a team as a code owner December 6, 2024 13:41
@victorr victorr requested a review from scellef December 6, 2024 13:41
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 6, 2024
@victorr victorr force-pushed the victorr/vault-32926-raft-seal-ha-challenge branch from ac832d5 to 4d0c74a Compare December 6, 2024 13:46
@victorr victorr requested review from sgmiller and a team December 6, 2024 13:46
Copy link

github-actions bot commented Dec 6, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Dec 6, 2024

CI Results:
All Go tests succeeded! ✅

@victorr victorr force-pushed the victorr/vault-32926-raft-seal-ha-challenge branch from 4d0c74a to 45bb276 Compare December 9, 2024 12:43
@victorr victorr force-pushed the victorr/vault-32926-raft-seal-ha-challenge branch from 45bb276 to c8fa9d3 Compare December 9, 2024 13:04
@victorr victorr merged commit 703897b into main Dec 9, 2024
92 checks passed
@victorr victorr deleted the victorr/vault-32926-raft-seal-ha-challenge branch December 9, 2024 13:50
@victorr victorr added backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent and removed backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants