Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use const for in relation to vault eventing metadata #29130

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

hashiblaum
Copy link
Member

@hashiblaum hashiblaum commented Dec 9, 2024

Description

What does this PR do?

Adds a const path for indicating the path metadata key used for in eventing

@hashiblaum hashiblaum requested a review from tvoran December 9, 2024 20:53
@hashiblaum hashiblaum requested a review from a team as a code owner December 9, 2024 20:53
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Dec 9, 2024

Build Results:
All builds succeeded! ✅

sdk/logical/events.go Outdated Show resolved Hide resolved
sdk/logical/events.go Show resolved Hide resolved
@hashiblaum hashiblaum added this to the 1.19.0-rc milestone Dec 10, 2024
@hashiblaum hashiblaum added backport/1.18.x backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Dec 10, 2024
@hashiblaum hashiblaum requested a review from tvoran December 10, 2024 20:52
tvoran
tvoran previously approved these changes Dec 10, 2024
sdk/logical/events.go Outdated Show resolved Hide resolved
sdk/logical/events.go Outdated Show resolved Hide resolved
@hashiblaum hashiblaum merged commit ca203c2 into main Dec 11, 2024
92 checks passed
@hashiblaum hashiblaum deleted the VAULT-32766-add-path-const branch December 11, 2024 22:34
@hashiblaum hashiblaum added backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent and removed backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Dec 16, 2024
Monkeychip pushed a commit that referenced this pull request Dec 18, 2024
* use const for  in relation to vault eventing metadata

* update comments

* fix comment lengths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants